From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD9A3C433FE for ; Tue, 5 Oct 2021 01:24:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96A4861406 for ; Tue, 5 Oct 2021 01:24:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230506AbhJEB0E (ORCPT ); Mon, 4 Oct 2021 21:26:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:33356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230097AbhJEB0B (ORCPT ); Mon, 4 Oct 2021 21:26:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6F4416140B; Tue, 5 Oct 2021 01:24:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633397051; bh=57LNnA6XsVpnlGoKJUQ0C8IgmbyCmlx3YFFD3e/WyOk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WFpCe1AmoQWQ66uZdkx10c2v2o/7M/02a4+v8fER2wGHrT3xXpKAHsVx4n7pUDX59 cyyKRboHXzpjccP3/mQH2jWP5pU5E9LLdKDWL/n/C8xmdT5mCa/CLsAHDJ/1dcYO+j 0RsSK9TLgdXM4Xltt3U5c92AE7yAo68ArgYS61tpx45JFP1WYwZorputd4pNGRaK42 dvvjoQaQoLF7H32lcqPhcPvoihXvrqQRDjK11R5AMflhCWyLnyNij7qI6yAnV2gD1f S9Pu8rm3LhBFpWGLb3O1ZLxMfEQoQHe2l6wHSho/TDwIw9iwhouZI7B+ZRRv5U3OEx Up4+hgxlI7cfQ== Date: Mon, 4 Oct 2021 18:24:10 -0700 From: Jakub Kicinski To: Andy Shevchenko Cc: Pablo Neira Ayuso , "Jose M. Guisado Gomez" , "David S. Miller" , Arnd Bergmann , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jozsef Kadlecsik , Florian Westphal , Hideaki YOSHIFUJI , David Ahern Subject: Re: [PATCH v1 net-next 1/1] net: Mark possible unused variables on stack with __maybe_unused Message-ID: <20211004182410.3f3496b9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20211001145056.12184-1-andriy.shevchenko@linux.intel.com> References: <20211001145056.12184-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Oct 2021 17:50:56 +0300 Andy Shevchenko wrote: > When compile with COMPILE_TEST=y the -Werror is implied. > If we run `make W=1` the first level warnings will become > the build errors. Some of them related to possible unused > variables. Hence, to allow clean build in such case, mark > them with __maybe_unused. > > Signed-off-by: Andy Shevchenko You need to split the socket and fib change from the netfilter ones. Those go via different sub-trees.