From: Tommaso Merciai <tomm.merciai@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: tomm.merciai@gmail.com,
"Forest Bond" <forest@alittletooquiet.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Lucas Henneman" <lucas.henneman@linaro.org>,
"Madhumitha Prabakaran" <madhumithabiw@gmail.com>,
"Yujia Qiao" <rapiz@foxmail.com>,
"Marcos Antonio de Jesus Filho" <mdejesusfilho@gmail.com>,
"Aldas Taraškevičius" <aldas60@gmail.com>,
"Deepak R Varma" <mh12gx2825@gmail.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v6 1/3] staging: vt6655: fix camelcase in bShortSlotTime
Date: Tue, 5 Oct 2021 00:31:56 +0200 [thread overview]
Message-ID: <20211004223200.70524-2-tomm.merciai@gmail.com> (raw)
In-Reply-To: <20211004223200.70524-1-tomm.merciai@gmail.com>
Replace camel case variable bShortSlotTime with snake case variable
short_slot_time. bShortSlotTime is a boolean variable, if true short
slot time is enabled, false not. Short Slot Time reduces the slot time
from 20 microseconds to 9 microseconds, where the slot time is
the maximum theoretical time for a frame to travel a network.
References:
- http://cciew.blogspot.com/2011/02/short-slot-time.html
- https://www.cse.wustl.edu/~jain/cse574-16/ftp/j_05lan4.pdf
- https://www.networkdatapedia.com/post/2013/09/16/ \
configuring-short-slot-time-to-improve-wifi-performance
- https://en.wikipedia.org/wiki/Slot_time
Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
---
Changes since v5:
- Fix variable name short_slot_time instead of b_short_slot_time
- Add more details in commit message
Changes since v4:
- Make the commit body message more clearer
Changes since v3:
- Fix patch changelog
Changes since v2:
- Add patch changelog
Changes since v1:
- Make the commit message more clearer
drivers/staging/vt6655/baseband.c | 4 ++--
drivers/staging/vt6655/card.c | 2 +-
drivers/staging/vt6655/device.h | 2 +-
drivers/staging/vt6655/device_main.c | 4 ++--
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index f73f3fad3e05..491cf4d8bc6c 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -2200,7 +2200,7 @@ bb_set_short_slot_time(struct vnt_private *priv)
bb_read_embedded(priv, 0x0A, &by_bb_rx_conf); /* CR10 */
- if (priv->bShortSlotTime)
+ if (priv->short_slot_time)
by_bb_rx_conf &= 0xDF; /* 1101 1111 */
else
by_bb_rx_conf |= 0x20; /* 0010 0000 */
@@ -2223,7 +2223,7 @@ void bb_set_vga_gain_offset(struct vnt_private *priv, unsigned char by_data)
/* patch for 3253B0 Baseband with Cardbus module */
if (by_data == priv->abyBBVGA[0])
by_bb_rx_conf |= 0x20; /* 0010 0000 */
- else if (priv->bShortSlotTime)
+ else if (priv->short_slot_time)
by_bb_rx_conf &= 0xDF; /* 1101 1111 */
else
by_bb_rx_conf |= 0x20; /* 0010 0000 */
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 3ef3a6e0e6e1..7fb8a74e2a78 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -258,7 +258,7 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type)
bb_write_embedded(priv, 0x88, 0x08);
bySIFS = C_SIFS_BG;
- if (priv->bShortSlotTime) {
+ if (priv->short_slot_time) {
bySlot = C_SLOT_SHORT;
byDIFS = C_SIFS_BG + 2 * C_SLOT_SHORT;
} else {
diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index 2af769174e33..49e3d09480f2 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -215,7 +215,7 @@ struct vnt_private {
bool bEncryptionEnable;
bool bLongHeader;
- bool bShortSlotTime;
+ bool short_slot_time;
bool bProtectMode;
bool bNonERPPresent;
bool bBarkerPreambleMd;
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index d40c2ac14928..52c2a6651bc9 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -1440,9 +1440,9 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,
if (changed & BSS_CHANGED_ERP_SLOT) {
if (conf->use_short_slot)
- priv->bShortSlotTime = true;
+ priv->short_slot_time = true;
else
- priv->bShortSlotTime = false;
+ priv->short_slot_time = false;
CARDbSetPhyParameter(priv, priv->byBBType);
bb_set_vga_gain_offset(priv, priv->abyBBVGA[0]);
--
2.25.1
next prev parent reply other threads:[~2021-10-04 22:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 22:31 [PATCH v6 0/3] staging: vt6655: replace camel case variables Tommaso Merciai
2021-10-04 22:31 ` Tommaso Merciai [this message]
2021-10-04 22:31 ` [PATCH v6 2/3] staging: vt6655: fix camelcase in ldBmThreshold Tommaso Merciai
2021-10-05 8:39 ` Dan Carpenter
2021-10-05 20:30 ` Tommaso Merciai
2021-10-04 22:31 ` [PATCH v6 3/3] staging: vt6655: fix camelcase in PortOffset Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004223200.70524-2-tomm.merciai@gmail.com \
--to=tomm.merciai@gmail.com \
--cc=aldas60@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lucas.henneman@linaro.org \
--cc=madhumithabiw@gmail.com \
--cc=mdejesusfilho@gmail.com \
--cc=mh12gx2825@gmail.com \
--cc=rapiz@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).