From: Daniel Thompson <daniel.thompson@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: phone-devel@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
Pavel Dubrova <pashadubrova@gmail.com>,
Kiran Gunda <kgunda@codeaurora.org>,
Courtney Cavin <courtney.cavin@sonymobile.com>,
Bryan Wu <cooloney@gmail.com>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] backlight: qcom-wled: Use cpu_to_le16 macro to perform conversion
Date: Tue, 5 Oct 2021 10:06:59 +0100 [thread overview]
Message-ID: <20211005090659.rt4bxlkvbabwsiru@maple.lan> (raw)
In-Reply-To: <20211004192741.621870-3-marijn.suijten@somainline.org>
On Mon, Oct 04, 2021 at 09:27:33PM +0200, Marijn Suijten wrote:
> The kernel already provides appropriate primitives to perform endianness
> conversion which should be used in favour of manual bit-wrangling.
>
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/video/backlight/qcom-wled.c | 25 +++++++++++--------------
> 1 file changed, 11 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
> index 6af808af2328..9927ed98944a 100644
> --- a/drivers/video/backlight/qcom-wled.c
> +++ b/drivers/video/backlight/qcom-wled.c
> @@ -231,14 +231,14 @@ struct wled {
> static int wled3_set_brightness(struct wled *wled, u16 brightness)
> {
> int rc, i;
> - u8 v[2];
> + u16 v;
>
> - v[0] = brightness & 0xff;
> - v[1] = (brightness >> 8) & 0xf;
> + v = cpu_to_le16(brightness & WLED3_SINK_REG_BRIGHT_MAX);
>
> for (i = 0; i < wled->cfg.num_strings; ++i) {
> rc = regmap_bulk_write(wled->regmap, wled->ctrl_addr +
> - WLED3_SINK_REG_BRIGHT(i), v, 2);
> + WLED3_SINK_REG_BRIGHT(i),
> + &v, sizeof(v));
> if (rc < 0)
> return rc;
> }
> @@ -249,19 +249,18 @@ static int wled3_set_brightness(struct wled *wled, u16 brightness)
> static int wled4_set_brightness(struct wled *wled, u16 brightness)
> {
> int rc, i;
> - u16 low_limit = wled->max_brightness * 4 / 1000;
> - u8 v[2];
> + u16 v, low_limit = wled->max_brightness * 4 / 1000;
>
> /* WLED4's lower limit of operation is 0.4% */
> if (brightness > 0 && brightness < low_limit)
> brightness = low_limit;
>
> - v[0] = brightness & 0xff;
> - v[1] = (brightness >> 8) & 0xf;
> + v = cpu_to_le16(brightness & WLED3_SINK_REG_BRIGHT_MAX);
>
> for (i = 0; i < wled->cfg.num_strings; ++i) {
> rc = regmap_bulk_write(wled->regmap, wled->sink_addr +
> - WLED4_SINK_REG_BRIGHT(i), v, 2);
> + WLED4_SINK_REG_BRIGHT(i),
> + &v, sizeof(v));
> if (rc < 0)
> return rc;
> }
> @@ -272,22 +271,20 @@ static int wled4_set_brightness(struct wled *wled, u16 brightness)
> static int wled5_set_brightness(struct wled *wled, u16 brightness)
> {
> int rc, offset;
> - u16 low_limit = wled->max_brightness * 1 / 1000;
> - u8 v[2];
> + u16 v, low_limit = wled->max_brightness * 1 / 1000;
>
> /* WLED5's lower limit is 0.1% */
> if (brightness < low_limit)
> brightness = low_limit;
>
> - v[0] = brightness & 0xff;
> - v[1] = (brightness >> 8) & 0x7f;
> + v = cpu_to_le16(brightness & WLED5_SINK_REG_BRIGHT_MAX_15B);
>
> offset = (wled->cfg.mod_sel == MOD_A) ?
> WLED5_SINK_REG_MOD_A_BRIGHTNESS_LSB :
> WLED5_SINK_REG_MOD_B_BRIGHTNESS_LSB;
>
> rc = regmap_bulk_write(wled->regmap, wled->sink_addr + offset,
> - v, 2);
> + &v, sizeof(v));
> return rc;
> }
>
> --
> 2.33.0
>
next prev parent reply other threads:[~2021-10-05 9:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 19:27 [PATCH 00/10] backlight: qcom-wled: fix and solidify handling of enabled-strings Marijn Suijten
2021-10-04 19:27 ` [PATCH 01/10] backlight: qcom-wled: Pass number of elements to read to read_u32_array Marijn Suijten
2021-10-05 9:05 ` Daniel Thompson
2021-10-04 19:27 ` [PATCH 02/10] backlight: qcom-wled: Use cpu_to_le16 macro to perform conversion Marijn Suijten
2021-10-05 9:06 ` Daniel Thompson [this message]
2021-10-04 19:27 ` [PATCH 03/10] backlight: qcom-wled: Override num-strings when enabled-strings is set Marijn Suijten
2021-10-05 9:38 ` Daniel Thompson
2021-10-04 19:27 ` [PATCH 04/10] backlight: qcom-wled: Validate enabled string indices in DT Marijn Suijten
2021-10-05 9:14 ` Daniel Thompson
2021-10-05 10:03 ` Marijn Suijten
2021-10-05 10:42 ` Daniel Thompson
2021-10-04 19:27 ` [PATCH 05/10] backlight: qcom-wled: Fix off-by-one maximum with default num_strings Marijn Suijten
2021-10-05 9:19 ` Daniel Thompson
2021-10-05 10:06 ` Marijn Suijten
2021-10-05 10:38 ` Daniel Thompson
2021-10-05 10:53 ` Daniel Thompson
2021-10-05 11:44 ` Marijn Suijten
2021-10-05 14:03 ` Daniel Thompson
2021-10-05 15:23 ` Marijn Suijten
2021-10-05 16:24 ` Daniel Thompson
2021-10-05 16:50 ` Konrad Dybcio
2021-10-05 17:34 ` Marijn Suijten
2021-10-06 14:44 ` Daniel Thompson
2021-10-07 21:28 ` Marijn Suijten
2021-10-04 19:27 ` [PATCH 06/10] backlight: qcom-wled: Remove unnecessary 4th default string in wled3 Marijn Suijten
2021-10-05 9:20 ` Daniel Thompson
2021-10-04 19:27 ` [PATCH 07/10] backlight: qcom-wled: Provide enabled_strings default for wled 4 and 5 Marijn Suijten
2021-10-05 9:21 ` Daniel Thompson
2021-10-04 19:27 ` [PATCH 08/10] backlight: qcom-wled: Remove unnecessary double whitespace Marijn Suijten
2021-10-05 9:21 ` Daniel Thompson
2021-10-04 19:27 ` [PATCH 09/10] backlight: qcom-wled: Consistently use enabled-strings in set_brightness Marijn Suijten
2021-10-05 9:33 ` Daniel Thompson
2021-10-05 10:12 ` Marijn Suijten
2021-10-04 19:27 ` [PATCH 10/10] backlight: qcom-wled: Consider enabled_strings in autodetection Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005090659.rt4bxlkvbabwsiru@maple.lan \
--to=daniel.thompson@linaro.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=cooloney@gmail.com \
--cc=courtney.cavin@sonymobile.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jami.kettunen@somainline.org \
--cc=jingoohan1@gmail.com \
--cc=kgunda@codeaurora.org \
--cc=konrad.dybcio@somainline.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=pashadubrova@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).