Re: [PATCH v3 6/8] PCI/AER: Clear error device AER registers in aer_irq()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3710 bytes --]

Hi Naveen,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on helgaas-pci/next]
[also build test WARNING on linux/master linus/master v5.15-rc3 next-20210921]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Naveen-Naidu/Fix-long-standing-AER-Error-Handling-Issues/20211004-223758
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-a006-20211004 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c0039de2953d15815448b4b3c3bafb45607781e0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ab727f8771a49bb5f4c7bbf10dc9ba9b90a454cf
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Naveen-Naidu/Fix-long-standing-AER-Error-Handling-Issues/20211004-223758
        git checkout ab727f8771a49bb5f4c7bbf10dc9ba9b90a454cf
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/pci/pcie/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/pci/pcie/aer.c:822: warning: Function parameter or member 'e_dev' not described in 'add_error_device'
   drivers/pci/pcie/aer.c:822: warning: Excess function parameter 'e_info' description in 'add_error_device'
   drivers/pci/pcie/aer.c:923: warning: Function parameter or member 'e_dev' not described in 'find_source_device'
   drivers/pci/pcie/aer.c:923: warning: Excess function parameter 'e_info' description in 'find_source_device'
>> drivers/pci/pcie/aer.c:1172: warning: expecting prototype for aer_find_corr_error_source_device(). Prototype was for aer_find_uncorr_error_source_device() instead


vim +1172 drivers/pci/pcie/aer.c

  1156	
  1157	/**
  1158	 * aer_find_corr_error_source_device - find the error source which detected the uncorrected error
  1159	 * @rp: pointer to Root Port pci_dev data structure
  1160	 * @e_src: pointer to an error source
  1161	 * @e_info: including detailed error information such like id
  1162	 *
  1163	 * Return true if found.
  1164	 *
  1165	 * Process the error information received at the Root Port, set these values
  1166	 * in the aer_devices_err_info and find all the devices that are related to
  1167	 * the error.
  1168	 */
  1169	static bool aer_find_uncorr_error_source_device(struct pci_dev *rp,
  1170						struct aer_err_source *e_src,
  1171						struct aer_devices_err_info *e_info)
> 1172	{
  1173		if (e_src->status & PCI_ERR_ROOT_UNCOR_RCV) {
  1174			e_info->err_info.id = ERR_UNCOR_ID(e_src->id);
  1175	
  1176			if (e_src->status & PCI_ERR_ROOT_FATAL_RCV)
  1177				e_info->err_info.severity = AER_FATAL;
  1178			else
  1179				e_info->err_info.severity = AER_NONFATAL;
  1180	
  1181			if (e_src->status & PCI_ERR_ROOT_MULTI_UNCOR_RCV)
  1182				e_info->err_info.multi_error_valid = 1;
  1183			else
  1184				e_info->err_info.multi_error_valid = 0;
  1185	
  1186			if (!find_source_device(rp, e_info))
  1187				return false;
  1188		}
  1189	
  1190		return true;
  1191	}
  1192	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41518 bytes --]