From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Steve Longerbeam <slongerbeam@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] i.MX6: Support 16-bit BT.1120 video input
Date: Wed, 6 Oct 2021 11:45:26 +0300 [thread overview]
Message-ID: <20211006084526.GA2048@kadam> (raw)
In-Reply-To: <m3o882n0ir.fsf@t19.piap.pl>
On Wed, Oct 06, 2021 at 08:13:48AM +0200, Krzysztof Hałasa wrote:
> @@ -373,11 +387,18 @@ static int fill_csi_bus_cfg(struct ipu_csi_bus_config *csicfg,
> break;
> case V4L2_MBUS_BT656:
> csicfg->ext_vsync = 0;
> + /* UYVY10_1X20 etc. should be supported as well */
> + is_bt1120 = mbus_fmt->code == MEDIA_BUS_FMT_UYVY8_1X16 ||
> + mbus_fmt->code == MEDIA_BUS_FMT_YUYV8_1X16;
Could you align better for readability, otherwise it's harder to spot
the two characters which are swapped between those to macros. (Also
it's basically normal for both sides of a || to be aligned...)
is_bt1120 = (mbus_fmt->code == MEDIA_BUS_FMT_UYVY8_1X16 ||
mbus_fmt->code == MEDIA_BUS_FMT_YUYV8_1X16);
> if (V4L2_FIELD_HAS_BOTH(mbus_fmt->field) ||
> mbus_fmt->field == V4L2_FIELD_ALTERNATE)
> - csicfg->clk_mode = IPU_CSI_CLK_MODE_CCIR656_INTERLACED;
> + csicfg->clk_mode = is_bt1120 ?
> + IPU_CSI_CLK_MODE_CCIR1120_INTERLACED_SDR :
> + IPU_CSI_CLK_MODE_CCIR656_INTERLACED;
> else
> - csicfg->clk_mode = IPU_CSI_CLK_MODE_CCIR656_PROGRESSIVE;
> + csicfg->clk_mode = is_bt1120 ?
> + IPU_CSI_CLK_MODE_CCIR1120_PROGRESSIVE_SDR :
> + IPU_CSI_CLK_MODE_CCIR656_PROGRESSIVE;
> break;
> case V4L2_MBUS_CSI2_DPHY:
> /*
regards,
dan carpenter
next prev parent reply other threads:[~2021-10-06 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 6:13 [PATCH] i.MX6: Support 16-bit BT.1120 video input Krzysztof Hałasa
2021-10-06 8:45 ` Dan Carpenter [this message]
2021-10-06 9:36 ` Philipp Zabel
2021-10-06 10:52 ` Krzysztof Hałasa
2021-10-08 11:53 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211006084526.GA2048@kadam \
--to=dan.carpenter@oracle.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=khalasa@piap.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).