From: Francesco Dolcini <francesco.dolcini@toradex.com>
To: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: philippe.schenker@toradex.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: micrel: ksz9131 led errata workaround
Date: Wed, 6 Oct 2021 11:39:55 +0200 [thread overview]
Message-ID: <20211006093955.GA428529@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <20211006073755.429469-1-francesco.dolcini@toradex.com>
Hello,
the link to the errata in the commit message is wrong, the correct
one is https://ww1.microchip.com/downloads/en/DeviceDoc/KSZ9131RNX-Silicon-Errata-and-Data-Sheet-Clarification-80000863B.pdf, I will fix it in the next patch version.
Francesco
On Wed, Oct 06, 2021 at 09:37:55AM +0200, Francesco Dolcini wrote:
> Micrel KSZ9131 PHY LED behavior is not correct when configured in
> Individual Mode, LED1 (Activity LED) is in the ON state when there is
> no-link.
>
> Workaround this by setting bit 9 of register 0x1e after verifying that
> the LED configuration is Individual Mode.
>
> This issue is described in KSZ9131RNX Silicon Errata DS80000693B
> (http://ww1.microchip.com/downloads/en/DeviceDoc/80000863A.pdf) and
> according to that it will not be corrected in a future silicon revision.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> drivers/net/phy/micrel.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index c330a5a9f665..661dedec84c4 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -1003,6 +1003,23 @@ static int ksz9131_config_rgmii_delay(struct phy_device *phydev)
> txcdll_val);
> }
>
> +/* Silicon Errata DS80000693B
> + *
> + * When LEDs are configured in Individual Mode, LED1 is ON in a no-link
> + * condition. Workaround is to set register 0x1e, bit 9, this way LED1 behaves
> + * according to the datasheet (off if there is no link).
> + */
> +
> +static int ksz9131_led_errata(struct phy_device *phydev)
> +{
> + int ret = 0;
> +
> + if (phy_read_mmd(phydev, 2, 0) & BIT(4))
> + ret = phy_set_bits(phydev, 0x1e, BIT(9));
> +
> + return ret;
> +}
> +
> static int ksz9131_config_init(struct phy_device *phydev)
> {
> struct device_node *of_node;
> @@ -1058,6 +1075,10 @@ static int ksz9131_config_init(struct phy_device *phydev)
> if (ret < 0)
> return ret;
>
> + ret = ksz9131_led_errata(phydev);
> + if (ret < 0)
> + return ret;
> +
> return 0;
> }
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-10-06 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 7:37 [PATCH] net: phy: micrel: ksz9131 led errata workaround Francesco Dolcini
2021-10-06 9:39 ` Francesco Dolcini [this message]
2021-10-06 21:57 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211006093955.GA428529@francesco-nb.int.toradex.com \
--to=francesco.dolcini@toradex.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=philippe.schenker@toradex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).