From: Jakub Kicinski <kuba@kernel.org>
To: Richard Palethorpe <rpalethorpe@suse.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Stefano Garzarella <sgarzare@redhat.com>,
Andra Paraschiv <andraprs@amazon.com>,
Eric Dumazet <edumazet@google.com>,
Arseny Krasnov <arseny.krasnov@kaspersky.com>,
Willem de Bruijn <willemb@google.com>,
Deepa Dinamani <deepa.kernel@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Richard Palethorpe <rpalethorpe@richiejp.com>
Subject: Re: [PATCH v2 2/2] vsock: Enable y2038 safe timeval for timeout
Date: Thu, 7 Oct 2021 09:04:04 -0700 [thread overview]
Message-ID: <20211007090404.20e555d4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20211007123147.5780-2-rpalethorpe@suse.com>
On Thu, 7 Oct 2021 13:31:47 +0100 Richard Palethorpe wrote:
> Reuse the timeval compat code from core/sock to handle 32-bit and
> 64-bit timeval structures. Also introduce a new socket option define
> to allow using y2038 safe timeval under 32-bit.
>
> The existing behavior of sock_set_timeout and vsock's timeout setter
> differ when the time value is out of bounds. vsocks current behavior
> is retained at the expense of not being able to share the full
> implementation.
>
> This allows the LTP test vsock01 to pass under 32-bit compat mode.
>
> Fixes: fe0c72f3db11 ("socket: move compat timeout handling into sock.c")
> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
> Cc: Richard Palethorpe <rpalethorpe@richiejp.com>
This breaks 32bit x86 build:
ERROR: modpost: "__divdi3" [net/vmw_vsock/vsock.ko] undefined!
If the 64 bit division is intention you need to use an appropriate
helper.
next prev parent reply other threads:[~2021-10-07 16:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 12:31 [PATCH v2 1/2] vsock: Refactor vsock_*_getsockopt to resemble sock_getsockopt Richard Palethorpe
2021-10-07 12:31 ` [PATCH v2 2/2] vsock: Enable y2038 safe timeval for timeout Richard Palethorpe
2021-10-07 12:53 ` Arnd Bergmann
2021-10-07 16:04 ` Jakub Kicinski [this message]
2021-10-07 17:14 ` Richard Palethorpe
2021-10-07 12:51 ` [PATCH v2 1/2] vsock: Refactor vsock_*_getsockopt to resemble sock_getsockopt Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007090404.20e555d4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andraprs@amazon.com \
--cc=arnd@arndb.de \
--cc=arseny.krasnov@kaspersky.com \
--cc=davem@davemloft.net \
--cc=deepa.kernel@gmail.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rpalethorpe@richiejp.com \
--cc=rpalethorpe@suse.com \
--cc=sgarzare@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).