From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-media@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
linux@rasmusvillemoes.dk,
Thorsten Leemhuis <regressions@leemhuis.info>
Subject: Re: [PATCH v4 4/7] list.h: Replace kernel.h with the necessary inclusions
Date: Thu, 7 Oct 2021 17:16:35 +0100 [thread overview]
Message-ID: <20211007171635.2f161739@jic23-huawei> (raw)
In-Reply-To: <20211007154407.29746-5-andriy.shevchenko@linux.intel.com>
On Thu, 7 Oct 2021 18:44:04 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
>
> Replace kernel.h inclusion with the list of what is really being used.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/linux/list.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/list.h b/include/linux/list.h
> index f2af4b4aa4e9..5dc679b373da 100644
> --- a/include/linux/list.h
> +++ b/include/linux/list.h
> @@ -2,11 +2,13 @@
> #ifndef _LINUX_LIST_H
> #define _LINUX_LIST_H
>
> +#include <linux/container_of.h>
> +#include <linux/const.h>
> #include <linux/types.h>
> #include <linux/stddef.h>
> #include <linux/poison.h>
Is there a reason you didn't quite sort this into alphabetical order?
> -#include <linux/const.h>
> -#include <linux/kernel.h>
> +
> +#include <asm/barrier.h>
>
> /*
> * Circular doubly linked list implementation.
next prev parent reply other threads:[~2021-10-07 16:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 15:44 [PATCH v4 0/7] kernel.h further split Andy Shevchenko
2021-10-07 15:44 ` [PATCH v4 1/7] kernel.h: Drop unneeded <linux/kernel.h> inclusion from other headers Andy Shevchenko
2021-10-07 15:44 ` [PATCH v4 2/7] kernel.h: Split out container_of() and typeof_member() macros Andy Shevchenko
2021-10-07 15:54 ` Miguel Ojeda
2021-10-07 16:08 ` Andy Shevchenko
2021-10-07 16:27 ` Joe Perches
2021-10-07 16:47 ` Andy Shevchenko
2021-10-11 9:07 ` David Laight
2021-10-07 15:44 ` [PATCH v4 3/7] kunit: Replace kernel.h with the necessary inclusions Andy Shevchenko
2021-10-07 15:44 ` [PATCH v4 4/7] list.h: " Andy Shevchenko
2021-10-07 16:16 ` Jonathan Cameron [this message]
2021-10-07 16:21 ` Andy Shevchenko
2021-10-07 16:22 ` Andy Shevchenko
2021-10-07 17:29 ` Laurent Pinchart
2021-10-09 0:59 ` Joe Perches
2021-10-09 1:21 ` Laurent Pinchart
2021-10-07 15:44 ` [PATCH v4 5/7] llist: " Andy Shevchenko
2021-10-07 15:44 ` [PATCH v4 6/7] plist: " Andy Shevchenko
2021-10-07 17:12 ` Joe Perches
2021-10-07 17:19 ` Andy Shevchenko
2021-10-07 17:26 ` Joe Perches
2021-10-07 17:32 ` Andy Shevchenko
2021-10-07 17:46 ` Joe Perches
2021-10-07 15:44 ` [PATCH v4 7/7] media: entity: " Andy Shevchenko
2021-10-07 16:50 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007171635.2f161739@jic23-huawei \
--to=jic23@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=boqun.feng@gmail.com \
--cc=brendanhiggins@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=longman@redhat.com \
--cc=mchehab@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=regressions@leemhuis.info \
--cc=sakari.ailus@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).