From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 259BCC433F5 for ; Fri, 8 Oct 2021 11:35:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08BED60F35 for ; Fri, 8 Oct 2021 11:35:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242252AbhJHLhK (ORCPT ); Fri, 8 Oct 2021 07:37:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:59712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241896AbhJHLeU (ORCPT ); Fri, 8 Oct 2021 07:34:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7DC4460F51; Fri, 8 Oct 2021 11:31:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633692701; bh=JkJkVKyNFeksWGCOSPKeNW84kfAAXyVxAhH5jI2oGMU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=duIrKY9mhf+ZFYKvyZtHZhgZagXETwG2+fQgfPGykPSQAC33LLlzFulLk6aJoFA7E qfPnTVvN9dJTzy+tsDAqftfx2boqKtlSn3XvmFkzQ2yuXXHo6oIhYmJjBlc6rISQu6 bsSM9mWXaWOWwYJgRDtEVKZk5vou5LQdwj0nJGz8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jan Beulich , Paul Durrant , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 08/29] xen-netback: correct success/error reporting for the SKB-with-fraglist case Date: Fri, 8 Oct 2021 13:27:55 +0200 Message-Id: <20211008112717.221613195@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211008112716.914501436@linuxfoundation.org> References: <20211008112716.914501436@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jan Beulich [ Upstream commit 3ede7f84c7c21f93c5eac611d60eba3f2c765e0f ] When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the special considerations for the head of the SKB no longer apply. Don't mistakenly report ERROR to the frontend for the first entry in the list, even if - from all I can tell - this shouldn't matter much as the overall transmit will need to be considered failed anyway. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/xen-netback/netback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 986b56970961..b0cbc7fead74 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -499,7 +499,7 @@ check_frags: * the header's copy failed, and they are * sharing a slot, send an error */ - if (i == 0 && sharedslot) + if (i == 0 && !first_shinfo && sharedslot) xenvif_idx_release(queue, pending_idx, XEN_NETIF_RSP_ERROR); else -- 2.33.0