From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77634C433F5 for ; Sat, 9 Oct 2021 01:01:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5877F60EBD for ; Sat, 9 Oct 2021 01:01:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244054AbhJIBDj (ORCPT ); Fri, 8 Oct 2021 21:03:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232037AbhJIBDg (ORCPT ); Fri, 8 Oct 2021 21:03:36 -0400 Received: from mail-qk1-x74a.google.com (mail-qk1-x74a.google.com [IPv6:2607:f8b0:4864:20::74a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E37BC061570 for ; Fri, 8 Oct 2021 18:01:40 -0700 (PDT) Received: by mail-qk1-x74a.google.com with SMTP id az37-20020a05620a172500b0045e43348ee8so9603900qkb.19 for ; Fri, 08 Oct 2021 18:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:message-id:mime-version:subject:from:to:cc; bh=2XmwK2K833EFOLIJ37ngWkEGrt3oRZzXMcCNeCxgUt8=; b=SC025lOceSrL6R2NfEHW+1SG5OZ9xeLPjd1eipxsnCviLmnH7udp7jPgvu7dZDugwy Qfv4MFmr85/b3FP1zVVeBS64mxu8ZfVL782E8y4h3mC14eVMd9mHPAr1YzjNZlcj/SO9 Ckt8eQj5sywPNjVt8kRi87iiMhein1EVB5wMjXI0v/lStKpPF+9IQl77Op2q4Q9gKo+E IRPHGIWDHK33IxRZZ2Vms1cc0cQOk+QBucaCCKVctW3YXrqBSNsJajq3uDGkvpeihlI+ skbz2lKmBXLRWCitCiFkG6vmUDjZ/PzZNLqueG3Qj/bRaC2jmzfm5EiU0UHF5qVoDxxy eDpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:message-id:mime-version:subject :from:to:cc; bh=2XmwK2K833EFOLIJ37ngWkEGrt3oRZzXMcCNeCxgUt8=; b=t4QevHCn2TCjE4ZOLima1ZeffVKJSHyzkQLIELDeRVdTLQSY74pM7OAwUPlbrsSGBu JNPTLnJlu7bWvlSwpiEDWSipCI8b94CXsDxSF6dmHb+ZhPp5jhu7gdzoGvvIQT0txAKb Jbri/s43W086dv6V7HJQThwA0GBlRmC1MYcYXfadhLWAiWDaHPKi34qNgw6Ygkcbc7Oz +ttAmpeunIPVfIz70QESaGFFF23kZqFXwLu01J2iyyA26bUu+B/CTYGC1FV6cUygppqR 0BdTfJSXKCotEdS0L/YOdj7xAR7f2ed78EaU9Kea2Zjlm7mRQEcZy0SeNQp0mLA5dWmy 3mgw== X-Gm-Message-State: AOAM531Y/cbLaUGBu1s0vUieu8XWRCuLVAO4MDxwjZGIPhcWjCbiWhTK pFri0oUj2QEew2jxbMAmWN9O/qTm+GE= X-Google-Smtp-Source: ABdhPJyImYrXiX4huD62GcgSUkgAGB2sC+Z7x6QVt8ecoJLUPZQusHnIg9Dk9iwp/Sa9e7cFfJw+0K4lQX8= X-Received: from seanjc798194.pdx.corp.google.com ([2620:15c:90:200:e39b:6333:b001:cb]) (user=seanjc job=sendgmr) by 2002:ac8:5a4f:: with SMTP id o15mr1663853qta.394.1633741298613; Fri, 08 Oct 2021 18:01:38 -0700 (PDT) Reply-To: Sean Christopherson Date: Fri, 8 Oct 2021 18:01:33 -0700 Message-Id: <20211009010135.4031460-1-seanjc@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.33.0.882.g93a45727a2-goog Subject: [PATCH 0/2] KVM: x86: Fix and cleanup for recent AVIC changes From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Maxim Levitsky Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Belated "code review" for Maxim's recent series to rework the AVIC inhibit code. Using the global APICv status in the page fault path is wrong as the correct status is always the vCPU's, since that status is accurate with respect to the time of the page fault. In a similar vein, the code to change the inhibit can be cleaned up since KVM can't rely on ordering between the update and the request for anything except consumers of the request. Sean Christopherson (2): KVM: x86/mmu: Use vCPU's APICv status when handling APIC_ACCESS memslot KVM: x86: Simplify APICv update request logic arch/x86/kvm/mmu/mmu.c | 2 +- arch/x86/kvm/x86.c | 16 +++++++--------- 2 files changed, 8 insertions(+), 10 deletions(-) -- 2.33.0.882.g93a45727a2-goog