linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Mark Gross <markgross@kernel.org>,
	Andy Shevchenko <andy@infradead.org>,
	Daniel Scally <djrscally@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>, Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Kate Hsuan <hpa@redhat.com>,
	linux-media@vger.kernel.org, linux-clk@vger.kernel.org
Subject: [PATCH v2 13/13] media: ipu3-cio2: Add module soft-deps for the INT3472 drivers
Date: Sat,  9 Oct 2021 18:05:48 +0200	[thread overview]
Message-ID: <20211009160548.306550-14-hdegoede@redhat.com> (raw)
In-Reply-To: <20211009160548.306550-1-hdegoede@redhat.com>

The clk and regulator frameworks expect clk/regulator consumer-devices
to have info about the consumed clks/regulators described in the device's
fw_node.

To work around this info missing from the ACPI tables on devices where
the int3472 driver is used, the int3472 MFD-cell drivers attach info about
consumers to the clks/regulators when registering these.

This causes problems with the probe ordering wrt drivers for consumers
of these clks/regulators. Since the lookups are only registered when the
provider-driver binds, trying to get these clks/regulators before then
results in a -ENOENT error for clks and a dummy regulator for regulators.

All the sensor ACPI fw-nodes have a _DEP dependency on the INT3472 ACPI
fw-node, so to work around these probe ordering issues the ACPI core
reports status.present and status.enabled as false for any ACPI devices
which have a dependency on an INT3472 ACPI device until all _DEP-s are met.

Our sensor-detect code in cio2-bridge.c depends on the status.present /
status.enabled fields. So the INT3472 driver (which fullfills the _DEP-s)
must be loaded before us to ensure the sensor-detect code works.
Add module soft-deps on the INT3472 drivers to ensure that they are loaded
first.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/media/pci/intel/ipu3/ipu3-cio2-main.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c b/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c
index 7bb86e246ebe..4db6b637f555 100644
--- a/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c
+++ b/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c
@@ -2063,3 +2063,9 @@ MODULE_AUTHOR("Yuning Pu <yuning.pu@intel.com>");
 MODULE_AUTHOR("Yong Zhi <yong.zhi@intel.com>");
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("IPU3 CIO2 driver");
+/*
+ * The sensor detection in cio2-bridge.c relies on adev->status.present/enabled
+ * which will only be true for sensors if their _DEP dependencies are met, which
+ * requires the INT3472 drivers to have loaded.
+ */
+MODULE_SOFTDEP("pre: intel_skl_int3472_discrete intel_skl_int3472_tps68470");
-- 
2.31.1


      parent reply	other threads:[~2021-10-09 16:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09 16:05 [PATCH v2 00/13] Add support for X86/ACPI camera sensor/PMIC setup with clk and regulator platform data Hans de Goede
2021-10-09 16:05 ` [PATCH v2 01/13] ACPI: Add a honor_deps flag to struct acpi_device Hans de Goede
2021-10-09 16:05 ` [PATCH v2 02/13] ACPI: honor dependencies for devices with a _DEP pointing to an INT3472 device Hans de Goede
2021-10-10 15:10   ` Hans de Goede
2021-10-09 16:05 ` [PATCH v2 03/13] platform_data: Add linux/platform_data/tps68470.h file Hans de Goede
2021-10-09 16:05 ` [PATCH v2 04/13] regulator: Introduce tps68470-regulator driver Hans de Goede
2021-10-11 11:02   ` Mark Brown
2021-10-09 16:05 ` [PATCH v2 05/13] clk: Introduce clk-tps68470 driver Hans de Goede
2021-10-09 16:05 ` [PATCH v2 06/13] platform/x86: int3472: Enable I2c daisy chain Hans de Goede
2021-10-09 16:05 ` [PATCH v2 07/13] platform/x86: int3472: Split into 2 drivers Hans de Goede
2021-10-09 16:05 ` [PATCH v2 08/13] platform/x86: int3472: Add get_sensor_adev_and_name() helper Hans de Goede
2021-10-09 16:05 ` [PATCH v2 09/13] platform/x86: int3472: Pass tps68470_clk_platform_data to the tps68470-regulator MFD-cell Hans de Goede
2021-10-09 16:05 ` [PATCH v2 10/13] platform/x86: int3472: Pass tps68470_regulator_platform_data " Hans de Goede
2021-10-09 16:05 ` [PATCH v2 11/13] platform/x86: int3472: Deal with probe ordering issues Hans de Goede
2021-10-09 16:05 ` [PATCH v2 12/13] media: ipu3-cio2: Add INT347A to cio2-bridge Hans de Goede
2021-10-09 16:05 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211009160548.306550-14-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=andy@infradead.org \
    --cc=broonie@kernel.org \
    --cc=djrscally@gmail.com \
    --cc=hpa@redhat.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=lenb@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).