From: Paul Cercueil <paul@crapouillou.net>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Harvey Hunt <harveyhuntnexus@gmail.com>
Cc: list@opendingux.net, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
Paul Cercueil <paul@crapouillou.net>
Subject: [PATCH 0/3] mtd: Ingenic NAND fix for JZ4740
Date: Sat, 9 Oct 2021 20:49:49 +0200 [thread overview]
Message-ID: <20211009184952.24591-1-paul@crapouillou.net> (raw)
Hi,
Looks like NAND support has been broken on the JZ4740 SoC for a while;
it looks like it comes from the fact that the "hw_oob_first" mechanism
was dropped from the NAND core and moved to the Davinci driver.
It turns out the JZ4740 SoC needs it too; I didn't notice it when
writing the new ingenic-nand driver (to replace the old jz4740-nand
driver) most likely because my Device Tree had the "nand-ecc-mode" set
to "hw_oob_first".
I am not very sure about patch [1/3]; to me the original code does not
make sense, and it didn't work out-of-the-box on the JZ4740 without it.
By applying patch [1/3] the function nand_read_page_hwecc_oob_first()
can be reused for the JZ4740 SoC as well. But I did not test patch [1/3]
on Davinci.
Cheers,
-Paul
Paul Cercueil (3):
mtd: rawnand/davinci: Don't calculate ECC when reading page
mtd: rawnand: Export nand_read_page_hwecc_oob_first()
mtd: rawnand/ingenic: JZ4740 needs 'oob_first' read page function
drivers/mtd/nand/raw/davinci_nand.c | 73 +------------------
.../mtd/nand/raw/ingenic/ingenic_nand_drv.c | 5 ++
drivers/mtd/nand/raw/nand_base.c | 69 ++++++++++++++++++
include/linux/mtd/rawnand.h | 2 +
4 files changed, 77 insertions(+), 72 deletions(-)
--
2.33.0
next reply other threads:[~2021-10-09 18:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 18:49 Paul Cercueil [this message]
2021-10-09 18:49 ` [PATCH 1/3] mtd: rawnand/davinci: Don't calculate ECC when reading page Paul Cercueil
2021-10-09 18:49 ` [PATCH 2/3] mtd: rawnand: Export nand_read_page_hwecc_oob_first() Paul Cercueil
2021-10-15 6:13 ` Miquel Raynal
2021-10-15 8:38 ` Paul Cercueil
2021-10-15 8:51 ` Miquel Raynal
2021-10-15 9:27 ` Paul Cercueil
2021-10-15 9:35 ` Miquel Raynal
2021-10-15 9:38 ` Paul Cercueil
2021-10-15 9:44 ` Miquel Raynal
2021-10-09 18:49 ` [PATCH 3/3] mtd: rawnand/ingenic: JZ4740 needs 'oob_first' read page function Paul Cercueil
2021-10-15 6:14 ` Miquel Raynal
2021-11-07 13:47 ` [PATCH 0/3] mtd: Ingenic NAND fix for JZ4740 H. Nikolaus Schaller
2021-11-07 18:43 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211009184952.24591-1-paul@crapouillou.net \
--to=paul@crapouillou.net \
--cc=harveyhuntnexus@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=list@opendingux.net \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).