From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E901C433F5 for ; Sun, 10 Oct 2021 13:51:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77377610CE for ; Sun, 10 Oct 2021 13:51:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232816AbhJJNws (ORCPT ); Sun, 10 Oct 2021 09:52:48 -0400 Received: from mail-m17638.qiye.163.com ([59.111.176.38]:33546 "EHLO mail-m17638.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231896AbhJJNwo (ORCPT ); Sun, 10 Oct 2021 09:52:44 -0400 Received: from amadeus-VLT-WX0.lan (unknown [58.23.36.250]) by mail-m17638.qiye.163.com (Hmail) with ESMTPA id 3B1A31C0189; Sun, 10 Oct 2021 21:50:42 +0800 (CST) From: Chukun Pan To: Chen-Yu Tsai Cc: Maxime Ripard , Rob Herring , Jernej Skrabec , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Chukun Pan Subject: [PATCH v2 0/1] arm64: dts: allwinner: NanoPi R1S H5: Add generic compatible string for I2C EEPROM Date: Sun, 10 Oct 2021 21:50:16 +0800 Message-Id: <20211010135017.6855-1-amadeus@jmu.edu.cn> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWUMZGElWTENDS0oYQhgaGk keVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWVVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Pz46Ejo6Oj4XETcJTgFCPxw4 CD0aCk9VSlVKTUhIQ0xIQ09JTEtDVTMWGhIXVRoWGh8eDgg7ERYOVR4fDlUYFUVZV1kSC1lBWU5D VUlIVUhNVUlOS1lXWQgBWUFJSElONwY+ X-HM-Tid: 0a7c6a7850ffd993kuws3b1a31c0189 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi ChenYu, > You should add the atmel compatible as a fallback one, not replace the > microchip one. Thanks for correcting, I did it, also upgrade the commit message. > Please also add a cell representing the MAC address, and hook it up > to the GMAC. You can find an example here [1]. Frankly speaking, I’m a little confused about this. There is a rtl8153 usb network card on this machine, the original factory seems to store its mac address on this eeprom. It seems that there is no usb network card written in dts in the kernel before, and the rtl8152 driver may also need to be modified accordingly to support reading the mac address from eeprom. Sorry for my bad English. Thanks, Chukun Changes from v2: * Typo fixes for the position format. * Add a nvmem cell representing the MAC address. Chukun Pan (1): arm64: dts: allwinner: NanoPi R1S H5: Add generic compatible string for I2C EEPROM .../arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) -- 2.17.1