From: Jonathan Cameron <jic23@kernel.org>
To: Mihail Chindris <mihail.chindris@analog.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<lars@metafoo.de>, <Michael.Hennerich@analog.com>,
<nuno.sa@analog.com>, <dragos.bogdan@analog.com>,
<alexandru.ardelean@analog.com>
Subject: Re: [PATCH v6 3/6] iio: triggered-buffer: extend support to configure output buffers
Date: Sun, 10 Oct 2021 17:21:13 +0100 [thread overview]
Message-ID: <20211010172113.239591a3@jic23-huawei> (raw)
In-Reply-To: <20211007080035.2531-4-mihail.chindris@analog.com>
On Thu, 7 Oct 2021 08:00:32 +0000
Mihail Chindris <mihail.chindris@analog.com> wrote:
> From: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
> Now that output (kfifo) buffers are supported, we need to extend the
> {devm_}iio_triggered_buffer_setup_ext() parameter list to take a direction
> parameter.
>
> This allows us to attach an output triggered buffer to a DAC device.
> Unfortunately it's a bit difficult to add another macro to avoid changing 5
> drivers where {devm_}iio_triggered_buffer_setup_ext() is used.
> Well, it's doable, but may not be worth the trouble vs just updating all
> these 5 drivers.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Signed-off-by: Mihail Chindris <mihail.chindris@analog.com>
This doesn't build... See inline and fixed whilst applying.
> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> index 28bde13003b7..e9f64da06f89 100644
> --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> @@ -360,8 +360,9 @@ int cros_ec_sensors_core_init(struct platform_device *pdev,
> * The only way to get samples in buffer is to set a
> * software trigger (systrig, hrtimer).
> */
> - ret = devm_iio_triggered_buffer_setup(dev, indio_dev,
> - NULL, trigger_capture, NULL);
This isn't the _ext form...
so dropped this change.
> + ret = devm_iio_triggered_buffer_setup_ext(dev,
> + indio_dev, NULL, trigger_capture,
> + IIO_BUFFER_DIRECTION_IN, NULL);
> if (ret)
> return ret;
> }
next prev parent reply other threads:[~2021-10-10 16:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 8:00 [PATCH v6 0/6] iio: Add output buffer support Mihail Chindris
2021-10-07 8:00 ` [PATCH v6 1/6] " Mihail Chindris
2021-10-07 16:05 ` Jonathan Cameron
2021-10-07 16:24 ` Chindris, Mihail
2021-10-07 17:04 ` Chindris, Mihail
2021-10-07 17:13 ` Jonathan Cameron
2021-10-08 6:56 ` Alexandru Ardelean
2021-10-10 16:10 ` Jonathan Cameron
2021-10-07 8:00 ` [PATCH v6 2/6] iio: kfifo-buffer: " Mihail Chindris
2021-10-07 8:00 ` [PATCH v6 3/6] iio: triggered-buffer: extend support to configure output buffers Mihail Chindris
2021-10-10 16:21 ` Jonathan Cameron [this message]
2021-10-07 8:00 ` [PATCH v6 4/6] drivers: iio: dac: ad5766: Fix dt property name Mihail Chindris
2021-10-07 15:51 ` Jonathan Cameron
2021-10-07 8:00 ` [PATCH v6 5/6] Documentation:devicetree:bindings:iio:dac: Fix val Mihail Chindris
2021-10-07 15:53 ` Jonathan Cameron
2021-10-07 8:00 ` [PATCH v6 6/6] drivers:iio:dac:ad5766.c: Add trigger buffer Mihail Chindris
2021-10-10 16:23 ` Jonathan Cameron
2021-10-07 8:10 ` [PATCH v6 0/6] iio: Add output buffer support Chindris, Mihail
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211010172113.239591a3@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=dragos.bogdan@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mihail.chindris@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).