From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74161C433FE for ; Mon, 11 Oct 2021 07:33:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58B4F60D07 for ; Mon, 11 Oct 2021 07:33:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234557AbhJKHfw (ORCPT ); Mon, 11 Oct 2021 03:35:52 -0400 Received: from verein.lst.de ([213.95.11.211]:36155 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234401AbhJKHfu (ORCPT ); Mon, 11 Oct 2021 03:35:50 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id AF37268AFE; Mon, 11 Oct 2021 09:33:48 +0200 (CEST) Date: Mon, 11 Oct 2021 09:33:48 +0200 From: Christoph Hellwig To: Simon Ser Cc: Alex Deucher , Christoph Hellwig , Stephen Rothwell , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build failure after merge of the amdgpu tree Message-ID: <20211011073348.GA10672@lst.de> References: <20211008113116.4bdd7b6c@canb.auug.org.au> <20211008192910.600a188d@canb.auug.org.au> <_POw9ikafXoqSFqiOb8SZb_uvRZ4okgD4qrl4EtJ0UBiQTV7pwV3pJIM20eIzmpuFWDeBF9NPD00r72ttX0mZZ0bNeH_J44MoaB-jfjrQSU=@emersion.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <_POw9ikafXoqSFqiOb8SZb_uvRZ4okgD4qrl4EtJ0UBiQTV7pwV3pJIM20eIzmpuFWDeBF9NPD00r72ttX0mZZ0bNeH_J44MoaB-jfjrQSU=@emersion.fr> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 08, 2021 at 06:07:33PM +0000, Simon Ser wrote: > Would it be reasonable to re-export get_mm_exe_file? amdgpu uses it here: > > https://gitlab.freedesktop.org/agd5f/linux/-/commit/0d4da915c7098eca2aa6f559f42e33b5e9c7c5e8 Seriously? No, it obviously not. Unexporting it is important to catch utter crap like in that commit which should have never made it into a maintainer tree.