From: Will Deacon <will@kernel.org>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: asm: vdso: gettimeofday: export common variables
Date: Mon, 11 Oct 2021 11:02:57 +0100 [thread overview]
Message-ID: <20211011100256.GA3681@willie-the-truck> (raw)
In-Reply-To: <20211007195754.678124-1-anders.roxell@linaro.org>
On Thu, Oct 07, 2021 at 09:57:54PM +0200, Anders Roxell wrote:
> When building the kernel with sparse enabled 'C=1' the following
> warnings can be seen:
>
> arch/arm64/kernel/vdso/vgettimeofday.c:9:5: warning: symbol '__kernel_clock_gettime' was not declared. Should it be static?
> arch/arm64/kernel/vdso/vgettimeofday.c:15:5: warning: symbol '__kernel_gettimeofday' was not declared. Should it be static?
> arch/arm64/kernel/vdso/vgettimeofday.c:21:5: warning: symbol '__kernel_clock_getres' was not declared. Should it be static?
>
> Rework so the variables are exported, since these variables are
> created and used in vdso/vgettimeofday.c, also used in vdso.lds.S.
Hmm, these functions are part of the vDSO and shouldn't be called from the
kernel, so I don't think it makes sense to add prototypes for them to a
kernel header, to be honest.
Will
next prev parent reply other threads:[~2021-10-11 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 19:57 [PATCH] arm64: asm: vdso: gettimeofday: export common variables Anders Roxell
2021-10-11 10:02 ` Will Deacon [this message]
2021-10-11 12:47 ` Arnd Bergmann
2021-10-11 13:33 ` Catalin Marinas
2023-01-09 7:48 ` Miles Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011100256.GA3681@willie-the-truck \
--to=will@kernel.org \
--cc=anders.roxell@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).