* [PATCH] selftests: bpf: Remove dumplicated include in cgroup_helpers
@ 2021-10-11 11:19 Wan Jiabing
2021-10-11 14:30 ` Daniel Borkmann
[not found] ` <ALUAmAB4EgbN1cS90y4NDarn.9.1633962609302.Hmail.wanjiabing@vivo.com>
0 siblings, 2 replies; 3+ messages in thread
From: Wan Jiabing @ 2021-10-11 11:19 UTC (permalink / raw)
To: Shuah Khan, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, linux-kselftest, netdev, bpf, linux-kernel
Cc: kael_w, Wan Jiabing
Fix following checkincludes.pl warning:
./tools/testing/selftests/bpf/cgroup_helpers.c
12 #include <unistd.h>
14 #include <unistd.h>
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
tools/testing/selftests/bpf/cgroup_helpers.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c
index 8fcd44841bb2..9d59c3990ca8 100644
--- a/tools/testing/selftests/bpf/cgroup_helpers.c
+++ b/tools/testing/selftests/bpf/cgroup_helpers.c
@@ -11,7 +11,6 @@
#include <fcntl.h>
#include <unistd.h>
#include <ftw.h>
-#include <unistd.h>
#include "cgroup_helpers.h"
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: bpf: Remove dumplicated include in cgroup_helpers
2021-10-11 11:19 [PATCH] selftests: bpf: Remove dumplicated include in cgroup_helpers Wan Jiabing
@ 2021-10-11 14:30 ` Daniel Borkmann
[not found] ` <ALUAmAB4EgbN1cS90y4NDarn.9.1633962609302.Hmail.wanjiabing@vivo.com>
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2021-10-11 14:30 UTC (permalink / raw)
To: Wan Jiabing, Shuah Khan, Alexei Starovoitov, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, linux-kselftest, netdev, bpf, linux-kernel
Cc: kael_w
On 10/11/21 1:19 PM, Wan Jiabing wrote:
> Fix following checkincludes.pl warning:
> ./tools/testing/selftests/bpf/cgroup_helpers.c
> 12 #include <unistd.h>
> 14 #include <unistd.h>
What does the 12 vs 14 mean here? Please provide a proper commit description, e.g. if
you used checkincludes.pl, maybe include the full command invocation and the relevant
output, so that this is more obvious and in a better shape. Thanks!
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> tools/testing/selftests/bpf/cgroup_helpers.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c
> index 8fcd44841bb2..9d59c3990ca8 100644
> --- a/tools/testing/selftests/bpf/cgroup_helpers.c
> +++ b/tools/testing/selftests/bpf/cgroup_helpers.c
> @@ -11,7 +11,6 @@
> #include <fcntl.h>
> #include <unistd.h>
> #include <ftw.h>
> -#include <unistd.h>
>
> #include "cgroup_helpers.h"
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: bpf: Remove duplicated include in cgroup_helpers
[not found] ` <ALUAmAB4EgbN1cS90y4NDarn.9.1633962609302.Hmail.wanjiabing@vivo.com>
@ 2021-10-12 2:20 ` Jiabing Wan
0 siblings, 0 replies; 3+ messages in thread
From: Jiabing Wan @ 2021-10-12 2:20 UTC (permalink / raw)
To: Daniel Borkmann, Wan Jiabing, Shuah Khan, Alexei Starovoitov,
Andrii Nakryiko, Martin KaFai Lau, Song Liu, Yonghong Song,
John Fastabend, KP Singh, linux-kselftest, netdev, bpf,
linux-kernel
Cc: kael_w
On 2021/10/11 22:30, Daniel Borkmann wrote:
> On 10/11/21 1:19 PM, Wan Jiabing wrote:
>> Fix following checkincludes.pl warning:
>> ./tools/testing/selftests/bpf/cgroup_helpers.c
>> 12 #include <unistd.h>
>> 14 #include <unistd.h>
>
> What does the 12 vs 14 mean here? Please provide a proper commit
> description, e.g. if
> you used checkincludes.pl, maybe include the full command invocation
> and the relevant
> output, so that this is more obvious and in a better shape. Thanks!
Sorry for my fuzzy description. 12 and 14 mean the line of includes file.
The script checkincludes.pl can only show which file is included
duplicated, like
./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
than once.
So I upgrade the script so it can tell me the position of the duplicated
includes.
I'll fix the description in v2.
>> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>> ---
>> tools/testing/selftests/bpf/cgroup_helpers.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c
>> b/tools/testing/selftests/bpf/cgroup_helpers.c
>> index 8fcd44841bb2..9d59c3990ca8 100644
>> --- a/tools/testing/selftests/bpf/cgroup_helpers.c
>> +++ b/tools/testing/selftests/bpf/cgroup_helpers.c
>> @@ -11,7 +11,6 @@
>> #include <fcntl.h>
>> #include <unistd.h>
>> #include <ftw.h>
>> -#include <unistd.h>
>> #include "cgroup_helpers.h"
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-12 2:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-11 11:19 [PATCH] selftests: bpf: Remove dumplicated include in cgroup_helpers Wan Jiabing
2021-10-11 14:30 ` Daniel Borkmann
[not found] ` <ALUAmAB4EgbN1cS90y4NDarn.9.1633962609302.Hmail.wanjiabing@vivo.com>
2021-10-12 2:20 ` [PATCH] selftests: bpf: Remove duplicated " Jiabing Wan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).