From: Hector Martin <marcan@marcan.st>
To: linux-arm-kernel@lists.infradead.org
Cc: Hector Martin <marcan@marcan.st>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Sven Peter <sven@svenpeter.dev>, Marc Zyngier <maz@kernel.org>,
Mark Kettenis <mark.kettenis@xs4all.nl>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Catalin Marinas <catalin.marinas@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH 6/9] memory: apple: Add apple-mcc driver to manage MCC perf in Apple SoCs
Date: Tue, 12 Oct 2021 01:57:04 +0900 [thread overview]
Message-ID: <20211011165707.138157-7-marcan@marcan.st> (raw)
In-Reply-To: <20211011165707.138157-1-marcan@marcan.st>
This driver binds to the memory controller hardware in Apple SoCs such
as the Apple M1, and provides a power domain that downstream devices can
use to change the performance state of the memory controller.
Signed-off-by: Hector Martin <marcan@marcan.st>
---
drivers/memory/Kconfig | 9 +++
drivers/memory/Makefile | 1 +
drivers/memory/apple-mcc.c | 130 +++++++++++++++++++++++++++++++++++++
3 files changed, 140 insertions(+)
create mode 100644 drivers/memory/apple-mcc.c
diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
index 72c0df129d5c..48ef3d563a1c 100644
--- a/drivers/memory/Kconfig
+++ b/drivers/memory/Kconfig
@@ -30,6 +30,15 @@ config ARM_PL172_MPMC
If you have an embedded system with an AMBA bus and a PL172
controller, say Y or M here.
+config APPLE_MCC
+ tristate "Apple SoC MCC driver"
+ default y if ARCH_APPLE
+ select PM_GENERIC_DOMAINS
+ depends on ARCH_APPLE || COMPILE_TEST
+ help
+ This driver manages performance tuning for the memory controller in
+ Apple SoCs, such as the Apple M1.
+
config ATMEL_SDRAMC
bool "Atmel (Multi-port DDR-)SDRAM Controller"
default y if ARCH_AT91
diff --git a/drivers/memory/Makefile b/drivers/memory/Makefile
index bc7663ed1c25..947840cbd2d4 100644
--- a/drivers/memory/Makefile
+++ b/drivers/memory/Makefile
@@ -8,6 +8,7 @@ ifeq ($(CONFIG_DDR),y)
obj-$(CONFIG_OF) += of_memory.o
endif
obj-$(CONFIG_ARM_PL172_MPMC) += pl172.o
+obj-$(CONFIG_APPLE_MCC) += apple-mcc.o
obj-$(CONFIG_ATMEL_SDRAMC) += atmel-sdramc.o
obj-$(CONFIG_ATMEL_EBI) += atmel-ebi.o
obj-$(CONFIG_BRCMSTB_DPFE) += brcmstb_dpfe.o
diff --git a/drivers/memory/apple-mcc.c b/drivers/memory/apple-mcc.c
new file mode 100644
index 000000000000..55959f034b9a
--- /dev/null
+++ b/drivers/memory/apple-mcc.c
@@ -0,0 +1,130 @@
+// SPDX-License-Identifier: GPL-2.0-only OR MIT
+/*
+ * Apple SoC MCC memory controller performance control driver
+ *
+ * Copyright The Asahi Linux Contributors
+ */
+
+#include <linux/delay.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/pm_domain.h>
+#include <linux/pm_opp.h>
+
+#define APPLE_MCC_PERF_CONFIG1 0xdc4
+#define APPLE_MCC_PERF_CONFIG2 0xdbc
+#define APPLE_MCC_CHANNEL(x) ((x) * 0x40000)
+
+struct apple_mcc {
+ struct device *dev;
+ struct generic_pm_domain genpd;
+ void __iomem *reg_base;
+ u32 num_channels;
+};
+
+#define to_apple_mcc(_genpd) container_of(_genpd, struct apple_mcc, genpd)
+
+static int apple_mcc_set_performance_state(struct generic_pm_domain *genpd, unsigned int state)
+{
+ struct apple_mcc *mcc = to_apple_mcc(genpd);
+ struct dev_pm_opp *opp;
+ struct device_node *np;
+ u32 perf_config[2];
+ unsigned int i;
+
+ dev_dbg(mcc->dev, "switching to perf state %d\n", state);
+
+ opp = dev_pm_opp_find_level_exact(&mcc->genpd.dev, state);
+ if (IS_ERR(opp))
+ return PTR_ERR(opp);
+
+ np = dev_pm_opp_get_of_node(opp);
+ if (of_property_read_u32_array(np, "apple,memory-perf-config",
+ perf_config, ARRAY_SIZE(perf_config))) {
+ dev_err(mcc->dev, "missing apple,memory-perf-config property");
+ of_node_put(np);
+ return -EINVAL;
+ }
+ of_node_put(np);
+
+ for (i = 0; i < mcc->num_channels; i++) {
+ writel_relaxed(perf_config[0],
+ mcc->reg_base + APPLE_MCC_CHANNEL(i) + APPLE_MCC_PERF_CONFIG1);
+ writel_relaxed(perf_config[1],
+ mcc->reg_base + APPLE_MCC_CHANNEL(i) + APPLE_MCC_PERF_CONFIG2);
+ }
+
+ return 0;
+}
+
+static unsigned int apple_mcc_opp_to_performance_state(struct generic_pm_domain *genpd,
+ struct dev_pm_opp *opp)
+{
+ return dev_pm_opp_get_level(opp);
+}
+
+static int apple_mcc_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct device_node *node = dev->of_node;
+ struct apple_mcc *mcc;
+ int ret;
+
+ mcc = devm_kzalloc(dev, sizeof(*mcc), GFP_KERNEL);
+ if (!mcc)
+ return -ENOMEM;
+
+ mcc->reg_base = devm_platform_ioremap_resource(pdev, 0);
+ if (IS_ERR(mcc->reg_base))
+ return PTR_ERR(mcc->reg_base);
+
+ if (of_property_read_u32(node, "apple,num-channels", &mcc->num_channels)) {
+ dev_err(dev, "missing apple,num-channels property\n");
+ return -ENOENT;
+ }
+
+ mcc->dev = dev;
+ mcc->genpd.name = "apple-mcc-perf";
+ mcc->genpd.opp_to_performance_state = apple_mcc_opp_to_performance_state;
+ mcc->genpd.set_performance_state = apple_mcc_set_performance_state;
+
+ ret = pm_genpd_init(&mcc->genpd, NULL, false);
+ if (ret < 0) {
+ dev_err(dev, "pm_genpd_init failed\n");
+ return ret;
+ }
+
+ ret = of_genpd_add_provider_simple_noclk(node, &mcc->genpd);
+ if (ret < 0) {
+ dev_err(dev, "of_genpd_add_provider_simple failed\n");
+ return ret;
+ }
+
+ dev_info(dev, "Apple MCC performance driver initialized\n");
+
+ return 0;
+}
+
+static const struct of_device_id apple_mcc_of_match[] = {
+ { .compatible = "apple,mcc" },
+ {}
+};
+
+MODULE_DEVICE_TABLE(of, apple_mcc_of_match);
+
+static struct platform_driver apple_mcc_driver = {
+ .probe = apple_mcc_probe,
+ .driver = {
+ .name = "apple-mcc",
+ .of_match_table = apple_mcc_of_match,
+ },
+};
+
+MODULE_AUTHOR("Hector Martin <marcan@marcan.st>");
+MODULE_DESCRIPTION("MCC memory controller performance tuning driver for Apple SoCs");
+MODULE_LICENSE("GPL v2");
+
+module_platform_driver(apple_mcc_driver);
--
2.33.0
next prev parent reply other threads:[~2021-10-11 16:59 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 16:56 [RFC PATCH 0/9] Apple SoC CPU P-state switching Hector Martin
2021-10-11 16:56 ` [RFC PATCH 1/9] MAINTAINERS: apple: Add apple-mcc and clk-apple-cluster paths Hector Martin
2021-10-11 16:57 ` [RFC PATCH 2/9] dt-bindings: memory-controller: Add apple,mcc binding Hector Martin
2021-10-12 8:48 ` Krzysztof Kozlowski
2021-10-19 22:43 ` Rob Herring
2021-10-11 16:57 ` [RFC PATCH 3/9] dt-bindings: clock: Add apple,cluster-clk binding Hector Martin
2021-10-12 8:51 ` Krzysztof Kozlowski
2021-10-12 9:35 ` Viresh Kumar
[not found] ` <D0DE08FE-562E-4A48-BCA0-9094DAFCA564@marcan.st>
[not found] ` <20211012094302.3cownyzr4phxwifs@vireshk-i7>
[not found] ` <64584F8C-D49F-41B5-9658-CF8A25186E67@marcan.st>
[not found] ` <20211012095735.mhh2lzu52ohtotl6@vireshk-i7>
2021-10-12 13:48 ` Hector Martin
2021-10-11 16:57 ` [RFC PATCH 4/9] opp: core: Don't warn if required OPP device does not exist Hector Martin
2021-10-12 3:21 ` Viresh Kumar
2021-10-12 5:34 ` Hector Martin
2021-10-12 5:51 ` Viresh Kumar
2021-10-12 5:57 ` Hector Martin
2021-10-12 9:26 ` Viresh Kumar
2021-10-12 9:31 ` Hector Martin "marcan"
2021-10-12 9:32 ` Viresh Kumar
2021-10-14 6:52 ` Hector Martin
2021-10-14 6:56 ` Viresh Kumar
2021-10-14 7:03 ` Hector Martin
2021-10-14 7:22 ` Viresh Kumar
2021-10-14 7:23 ` Hector Martin
2021-10-14 11:08 ` Ulf Hansson
2021-10-14 9:55 ` Ulf Hansson
2021-10-14 11:43 ` Hector Martin
2021-10-14 12:55 ` Ulf Hansson
2021-10-14 17:02 ` Hector Martin
2021-10-15 11:26 ` Ulf Hansson
2021-10-11 16:57 ` [RFC PATCH 5/9] PM: domains: Add of_genpd_add_provider_simple_noclk() Hector Martin
2021-10-11 16:57 ` Hector Martin [this message]
2021-10-12 9:19 ` [RFC PATCH 6/9] memory: apple: Add apple-mcc driver to manage MCC perf in Apple SoCs Krzysztof Kozlowski
2021-10-14 6:59 ` Hector Martin
2021-10-14 7:36 ` Krzysztof Kozlowski
2021-10-14 7:52 ` Hector Martin
2021-10-14 8:04 ` Krzysztof Kozlowski
2021-10-14 8:31 ` Hector Martin
2021-10-11 16:57 ` [RFC PATCH 7/9] clk: apple: Add clk-apple-cluster driver to manage CPU p-states Hector Martin
[not found] ` <163424925931.1688384.9647104000291025081@swboyd.mtv.corp.google.com>
2021-10-17 9:16 ` Hector Martin
2021-10-11 16:57 ` [RFC PATCH 8/9] arm64: apple: Select MEMORY and APPLE_MCC Hector Martin
2021-10-11 16:57 ` [RFC PATCH 9/9] arm64: apple: Add CPU frequency scaling support for t8103 Hector Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011165707.138157-7-marcan@marcan.st \
--to=marcan@marcan.st \
--cc=alyssa@rosenzweig.io \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.kettenis@xs4all.nl \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sven@svenpeter.dev \
--cc=ulf.hansson@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).