From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Jason Wang <jasowang@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Jens Axboe <axboe@kernel.dk>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Amit Shah <amit@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gonglei <arei.gonglei@huawei.com>,
"David S. Miller" <davem@davemloft.net>,
Sudeep Holla <sudeep.holla@arm.com>,
Cristian Marussi <cristian.marussi@arm.com>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
Viresh Kumar <vireshk@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
David Airlie <airlied@linux.ie>,
Gerd Hoffmann <kraxel@redhat.com>,
Daniel Vetter <daniel@ffwll.ch>, Jie Deng <jie.deng@intel.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
Kalle Valo <kvalo@codeaurora.org>,
Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>, Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Vivek Goyal <vgoyal@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Eric Van Hensbergen <ericvh@gmail.com>,
Latchesar Ionkov <lucho@ionkov.net>,
Dominique Martinet <asmadeus@codewreck.org>,
Stefano Garzarella <sgarzare@redhat.com>,
Anton Yakovlev <anton.yakovlev@opensynergy.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-um@lists.infradead.org,
virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org,
iommu@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, nvdimm@lists.linux.dev,
linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
v9fs-developer@lists.sourceforge.net, kvm@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH RFC] virtio: wrap config->reset calls
Date: Wed, 13 Oct 2021 08:17:49 -0400 [thread overview]
Message-ID: <20211013081632-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <2060bd96-5884-a1b5-9f29-7fe670dc088d@redhat.com>
On Wed, Oct 13, 2021 at 01:03:46PM +0200, David Hildenbrand wrote:
> On 13.10.21 12:55, Michael S. Tsirkin wrote:
> > This will enable cleanups down the road.
> > The idea is to disable cbs, then add "flush_queued_cbs" callback
> > as a parameter, this way drivers can flush any work
> > queued after callbacks have been disabled.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > arch/um/drivers/virt-pci.c | 2 +-
> > drivers/block/virtio_blk.c | 4 ++--
> > drivers/bluetooth/virtio_bt.c | 2 +-
> > drivers/char/hw_random/virtio-rng.c | 2 +-
> > drivers/char/virtio_console.c | 4 ++--
> > drivers/crypto/virtio/virtio_crypto_core.c | 8 ++++----
> > drivers/firmware/arm_scmi/virtio.c | 2 +-
> > drivers/gpio/gpio-virtio.c | 2 +-
> > drivers/gpu/drm/virtio/virtgpu_kms.c | 2 +-
> > drivers/i2c/busses/i2c-virtio.c | 2 +-
> > drivers/iommu/virtio-iommu.c | 2 +-
> > drivers/net/caif/caif_virtio.c | 2 +-
> > drivers/net/virtio_net.c | 4 ++--
> > drivers/net/wireless/mac80211_hwsim.c | 2 +-
> > drivers/nvdimm/virtio_pmem.c | 2 +-
> > drivers/rpmsg/virtio_rpmsg_bus.c | 2 +-
> > drivers/scsi/virtio_scsi.c | 2 +-
> > drivers/virtio/virtio.c | 5 +++++
> > drivers/virtio/virtio_balloon.c | 2 +-
> > drivers/virtio/virtio_input.c | 2 +-
> > drivers/virtio/virtio_mem.c | 2 +-
> > fs/fuse/virtio_fs.c | 4 ++--
> > include/linux/virtio.h | 1 +
> > net/9p/trans_virtio.c | 2 +-
> > net/vmw_vsock/virtio_transport.c | 4 ++--
> > sound/virtio/virtio_card.c | 4 ++--
> > 26 files changed, 39 insertions(+), 33 deletions(-)
> >
> > diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c
> > index c08066633023..22c4d87c9c15 100644
> > --- a/arch/um/drivers/virt-pci.c
> > +++ b/arch/um/drivers/virt-pci.c
> > @@ -616,7 +616,7 @@ static void um_pci_virtio_remove(struct virtio_device *vdev)
> > int i;
> > /* Stop all virtqueues */
> > - vdev->config->reset(vdev);
> > + virtio_reset_device(vdev);
> > vdev->config->del_vqs(vdev);
>
> Nit: virtio_device_reset()?
>
> Because I see:
>
> int virtio_device_freeze(struct virtio_device *dev);
> int virtio_device_restore(struct virtio_device *dev);
> void virtio_device_ready(struct virtio_device *dev)
>
> But well, there is:
> void virtio_break_device(struct virtio_device *dev);
Exactly. I don't know what's best, so I opted for plain english :)
> --
> Thanks,
>
> David / dhildenb
next prev parent reply other threads:[~2021-10-13 12:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 10:55 [PATCH RFC] virtio: wrap config->reset calls Michael S. Tsirkin
2021-10-13 11:00 ` Viresh Kumar
2021-10-13 11:03 ` David Hildenbrand
2021-10-13 12:17 ` Michael S. Tsirkin [this message]
2021-10-13 16:00 ` David Hildenbrand
2021-10-13 13:16 ` Vivek Goyal
2021-10-13 15:46 ` Mathieu Poirier
2021-10-13 16:18 ` Cristian Marussi
2021-10-13 16:26 ` Pankaj Gupta
2021-10-14 6:11 ` Anton Yakovlev
2021-10-14 8:36 ` Jean-Philippe Brucker
2021-10-17 14:12 ` Wolfram Sang
2021-10-18 9:11 ` Stefan Hajnoczi
2021-10-18 9:24 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013081632-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=amit@kernel.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=anton.yakovlev@opensynergy.com \
--cc=arei.gonglei@huawei.com \
--cc=arnd@arndb.de \
--cc=asmadeus@codewreck.org \
--cc=axboe@kernel.dk \
--cc=bjorn.andersson@linaro.org \
--cc=brgl@bgdev.pl \
--cc=cristian.marussi@arm.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=dave.jiang@intel.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ericvh@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=info@metux.net \
--cc=iommu@lists.linux-foundation.org \
--cc=ira.weiny@intel.com \
--cc=jasowang@redhat.com \
--cc=jdike@addtoit.com \
--cc=jean-philippe@linaro.org \
--cc=jejb@linux.ibm.com \
--cc=jie.deng@intel.com \
--cc=johan.hedberg@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=joro@8bytes.org \
--cc=kraxel@redhat.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=kvm@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=martin.petersen@oracle.com \
--cc=mathieu.poirier@linaro.org \
--cc=miklos@szeredi.hu \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=ohad@wizery.com \
--cc=pbonzini@redhat.com \
--cc=perex@perex.cz \
--cc=richard@nod.at \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=sudeep.holla@arm.com \
--cc=tiwai@suse.com \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=vgoyal@redhat.com \
--cc=vireshk@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=vishal.l.verma@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).