From: Dan Carpenter <dan.carpenter@oracle.com>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Straube <straube.linux@gmail.com>,
Martin Kaiser <martin@kaiser.cx>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
kael_w@yeah.net
Subject: Re: [PATCH] staging: r8188eu: use kzalloc instead of kmalloc and memset
Date: Wed, 13 Oct 2021 12:42:27 +0300 [thread overview]
Message-ID: <20211013094227.GJ8429@kadam> (raw)
In-Reply-To: <20211013070149.349-1-wanjiabing@vivo.com>
On Wed, Oct 13, 2021 at 03:01:28AM -0400, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/staging/r8188eu/os_dep/ioctl_linux.c:422:10-17:
> WARNING: kzalloc should be used for pwep, instead of kmalloc/memset
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/staging/r8188eu/os_dep/ioctl_linux.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> index 0201f6fbeb25..51f46696a593 100644
> --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> @@ -419,11 +419,10 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param,
> if (wep_key_len > 0) {
> wep_key_len = wep_key_len <= 5 ? 5 : 13;
> wep_total_len = wep_key_len + FIELD_OFFSET(struct ndis_802_11_wep, KeyMaterial);
> - pwep = kmalloc(wep_total_len, GFP_KERNEL);
> + pwep = kzalloc(wep_total_len, GFP_KERNEL);
> if (!pwep)
> goto exit;
Not related to your patch, but this is missing an error code as well.
It should be:
if (!pwep) {
ret = -ENOMEM;
goto exit;
}
regards,
dan carpenter
next prev parent reply other threads:[~2021-10-13 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 7:01 [PATCH] staging: r8188eu: use kzalloc instead of kmalloc and memset Wan Jiabing
2021-10-13 9:42 ` Dan Carpenter [this message]
2021-10-13 12:29 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013094227.GJ8429@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).