From: Andrew Halaney <ahalaney@redhat.com>
To: akpm@linux-foundation.org
Cc: rostedt@goodmis.org, bp@suse.de, rdunlap@infradead.org,
linux-kernel@vger.kernel.org,
Andrew Halaney <ahalaney@redhat.com>
Subject: [PATCH] init: Make unknown command line param message clearer
Date: Wed, 13 Oct 2021 17:35:02 -0500 [thread overview]
Message-ID: <20211013223502.96756-1-ahalaney@redhat.com> (raw)
The prior message is confusing users, which is the exact opposite of the
goal. If the message is being seen, one of the following situations is
happening:
1. the param is misspelled
2. the param is not valid due to the kernel configuration
3. the param is intended for init but isn't after the '--'
delineator on the command line
To make that more clear to the user, explicitly mention "kernel command
line" and also note that the params are still passed to user space to
avoid causing any alarm over params intended for init.
Fixes: 86d1919a4fb0 ("init: print out unknown kernel parameters")
Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
Here's v2 of this. I had to change the code a bit from what Steven
recommended to compile/look proper, but the intended format he had
suggested is still the same.
v1 -> v2:
* Print a much more concise message
v1: https://lore.kernel.org/all/20211012213523.39801-1-ahalaney@redhat.com/
Thanks,
Andrew
init/main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/init/main.c b/init/main.c
index ee4d3e1b3eb9..a286995449e2 100644
--- a/init/main.c
+++ b/init/main.c
@@ -925,7 +925,9 @@ static void __init print_unknown_bootoptions(void)
for (p = &envp_init[2]; *p; p++)
end += sprintf(end, " %s", *p);
- pr_notice("Unknown command line parameters:%s\n", unknown_options);
+ /* Start at unknown_options[1] to skip the initial space */
+ pr_notice("Unknown kernel command line parameters \"%s\", will be passed to user space.\n",
+ &unknown_options[1]);
memblock_free(unknown_options, len);
}
--
2.31.1
next reply other threads:[~2021-10-13 22:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 22:35 Andrew Halaney [this message]
2021-10-13 22:49 ` [PATCH] init: Make unknown command line param message clearer Randy Dunlap
2021-10-13 23:12 ` Andrew Morton
2021-10-14 12:47 ` Andrew Halaney
-- strict thread matches above, loose matches on Subject: below --
2021-10-12 21:35 Andrew Halaney
2021-10-13 0:01 ` Steven Rostedt
2021-10-13 0:18 ` Randy Dunlap
2021-10-13 0:22 ` Steven Rostedt
2021-10-13 12:56 ` Andrew Halaney
2021-10-13 13:03 ` Steven Rostedt
2021-10-13 13:10 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013223502.96756-1-ahalaney@redhat.com \
--to=ahalaney@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).