From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EE17C433EF for ; Thu, 14 Oct 2021 07:22:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3DDF60EE2 for ; Thu, 14 Oct 2021 07:22:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230054AbhJNHYw (ORCPT ); Thu, 14 Oct 2021 03:24:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229985AbhJNHYv (ORCPT ); Thu, 14 Oct 2021 03:24:51 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B32F5C061746 for ; Thu, 14 Oct 2021 00:22:46 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id i76so2523177pfe.13 for ; Thu, 14 Oct 2021 00:22:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0E4COH2ngrsNLXN5bCFa0OuHr0xwFVq3eN5FS8su8SI=; b=sZg2UBbzc5xYFuaYrGZAIEckcQgPOqz4j4cpz8yj5S1wsZoxSQgUoirPCursJASrNF 945CajmOzF8Dc4IJE2X3QtNug9AtGIc5CKtsfidTyY71GssDhuJQeNFlW1YdKChQUkUR 8ENOT6pYFRppbKljq3W7UFqT5UK4W3hAIccjNbSeaeMmVafHHYdFVwLBXLvStW5NK69K UlpiVVDGaMCX+lHYKau1JiaV31fkO5u7FfOpgzVTKcg+bktpfdesgHdTfXNHnZEXuLxW NVoSkZsV+I9wLdewHh0sPQ86HxdVqkSFC7lt7UnuvFLGiXeImsnquMTD3Ipf/oEcvyqV MsEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0E4COH2ngrsNLXN5bCFa0OuHr0xwFVq3eN5FS8su8SI=; b=jDp02lI44MXagLgDLbcKKtekk3iO8ndM7tveVMAiWkgG0o9lP2zPflLrfZbPsANXsj 8eggrZdlf0xBP0FQih6l5bki99/bhInavviUHDJQb0WhSYnr8I/PJmLMuHXwPhulP5oC V8kzoMAY8Le6k+UYY2LLgpmdnEcBWukAju9QiL5oL3Wc+IA8d6RGF1YZTvCAbQQvJlDJ UNJwPgdqK9BtVdFrkuBcxZEMEgrRRdgo64VQcwg6h+wBh7S6ntp0ymnqiC+zz1dwx2B8 3eSvYpQB1Zr4e2rybI4q3yOT10NW5oXrRTOxeS0yIYbQXuqAnbPEQIV5RhBz95xKDpqJ v5ug== X-Gm-Message-State: AOAM530wgnYCQJCx/C86dv8iaQ7XEoWTCPE8o9zFntLQXD/1ZDhugTPu WWBBerycELrM368dvY3O8O9IDw== X-Google-Smtp-Source: ABdhPJzZs4kh6M/dTz/1dja+i0gSblIEsU52ShMyg0/r5m5O8L8oyr8Q5S6iSy+DsP/OGZBF1kcsKQ== X-Received: by 2002:a62:8f8e:0:b0:44c:f130:9291 with SMTP id n136-20020a628f8e000000b0044cf1309291mr3853972pfd.19.1634196164780; Thu, 14 Oct 2021 00:22:44 -0700 (PDT) Received: from localhost ([106.201.113.61]) by smtp.gmail.com with ESMTPSA id y17sm1579348pfi.206.2021.10.14.00.22.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 00:22:44 -0700 (PDT) Date: Thu, 14 Oct 2021 12:52:42 +0530 From: Viresh Kumar To: Hector Martin Cc: Ulf Hansson , Sibi Sankar , Saravana Kannan , linux-arm-kernel@lists.infradead.org, Alyssa Rosenzweig , Sven Peter , Marc Zyngier , Mark Kettenis , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Viresh Kumar , Nishanth Menon , Catalin Marinas , "Rafael J. Wysocki" , Kevin Hilman , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 4/9] opp: core: Don't warn if required OPP device does not exist Message-ID: <20211014072242.bvj6exirqrct73vl@vireshk-i7> References: <20211012032144.2ltlpat7orrsyr6k@vireshk-i7> <20211012055143.xmkbvhbnolspgjin@vireshk-i7> <20211012092603.lkmhhjoo5v67wh44@vireshk-i7> <049FC437-EC38-4FE5-891E-5E25960892CF@marcan.st> <20211012093252.hb6rlcpxv5bmk7n3@vireshk-i7> <0db8e994-ac2c-8fad-55d0-1b5a9e2e21f2@marcan.st> <20211014065636.lkv77aqbugp3qhif@vireshk-i7> <039b77f3-d10e-bd7a-a594-b951a98bdd45@marcan.st> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <039b77f3-d10e-bd7a-a594-b951a98bdd45@marcan.st> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14-10-21, 16:03, Hector Martin wrote: > On 14/10/2021 15.56, Viresh Kumar wrote: > > > + /* > > > + * Attach the CPU device to its genpd domain (if any), to allow OPP > > > + * dependencies to be satisfied. > > > + */ > > > + ret = genpd_dev_pm_attach(cpu_dev); > > > + if (ret <= 0) { > > > + dev_err(cpu_dev, "Failed to attach CPU device to genpd\n"); > > > + goto out; > > > + } > > > + > > > > Other platform do this from some other place I think. > > > > Ulf, where should this code be moved ? cpu-clk driver ? > > > > I see one driver that does this is drivers/clk/qcom/apcs-sdx55.c (via > dev_pm_domain_attach). That may be a good place since you are already adding it and it is related to CPU clk. > Though it only does it for CPU#0; we need to do it > for all CPUs. Sure. -- viresh