From: Jan Kara <jack@suse.cz>
To: Shaoying Xu <shaoyi@amazon.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
fllinden@amazon.com, benh@amazon.com
Subject: Re: [PATCH 1/1] ext4: fix lazy initialization next schedule time computation in more granular unit
Date: Thu, 14 Oct 2021 11:56:57 +0200 [thread overview]
Message-ID: <20211014095657.GE15931@quack2.suse.cz> (raw)
In-Reply-To: <20210817225654.30487-2-shaoyi@amazon.com>
On Tue 17-08-21 22:56:54, Shaoying Xu wrote:
> Ext4 file system has default lazy inode table initialization setup once
> it is mounted. However, it has issue on computing the next schedule time
> that makes the timeout same amount in jiffies but different real time in
> secs if with various HZ values. Therefore, fix by measuring the current
> time in a more granular unit nanoseconds and make the next schedule time
> independent of the HZ value.
>
> Fixes: bfff68738f1c ("ext4: add support for lazy inode table initialization")
> Signed-off-by: Shaoying Xu <shaoyi@amazon.com>
> Cc: stable@vger.kernel.org
Thanks for the patch. It seems to have fallen through the cracks. It looks
good just some nits: The timeout will be still dependent on the HZ value
because we use jiffie-granular timer. But yes, I guess it is unnecessary
to make the imprecision 10x worse when we know we are likely dealing with
small numbers.
> @@ -3460,14 +3460,13 @@ static int ext4_run_li_request(struct ext4_li_request *elr)
> ret = 1;
>
> if (!ret) {
Please add a comment here so that we don't forget. Like:
/* Use ns-granular time as init can be really fast */
With this feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
> - timeout = jiffies;
> + start_time = ktime_get_real_ns();
> ret = ext4_init_inode_table(sb, group,
> elr->lr_timeout ? 0 : 1);
> trace_ext4_lazy_itable_init(sb, group);
> if (elr->lr_timeout == 0) {
> - timeout = (jiffies - timeout) *
> - EXT4_SB(elr->lr_super)->s_li_wait_mult;
> - elr->lr_timeout = timeout;
> + elr->lr_timeout = nsecs_to_jiffies((ktime_get_real_ns() - start_time) *
> + EXT4_SB(elr->lr_super)->s_li_wait_mult);
> }
> elr->lr_next_sched = jiffies + elr->lr_timeout;
> elr->lr_next_group = group + 1;
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2021-10-14 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 22:56 [PATCH 0/1] ext4: fix lazy initialization next schedule time computation in more granular unit Shaoying Xu
2021-08-17 22:56 ` [PATCH 1/1] " Shaoying Xu
2021-10-14 9:56 ` Jan Kara [this message]
2021-09-02 16:44 [PATCH 0/1] [RESEND] " Shaoying Xu
2021-09-02 16:44 ` [PATCH 1/1] " Shaoying Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014095657.GE15931@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=benh@amazon.com \
--cc=fllinden@amazon.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaoyi@amazon.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).