Re: [PATCH] iommu/iova: Add support for IOVA max alignment tuning

From: kernel test robot <lkp@intel.com>
To: Georgi Djakov <quic_c_gdjako@quicinc.com>,
	joro@8bytes.org, will@kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	akpm@linux-foundation.org, robin.murphy@arm.com,
	baolu.lu@linux.intel.com, corbet@lwn.net,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	iommu@lists.linux-foundation.org, djakov@kernel.org
Subject: Re: [PATCH] iommu/iova: Add support for IOVA max alignment tuning
Date: Thu, 14 Oct 2021 11:18:05 +0800	[thread overview]
Message-ID: <202110141149.U24tzw7A-lkp@intel.com> (raw)
In-Reply-To: <1634148667-409263-1-git-send-email-quic_c_gdjako@quicinc.com>

[-- Attachment #1: Type: text/plain, Size: 2990 bytes --]

Hi Georgi,

I love your patch! Yet something to improve:

[auto build test ERROR on joro-iommu/next]
[also build test ERROR on hnaz-mm/master linus/master v5.15-rc5 next-20211013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Georgi-Djakov/iommu-iova-Add-support-for-IOVA-max-alignment-tuning/20211014-021248
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: i386-randconfig-a003-20211013 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a8c695542b2987eb9a203d5663a0740cb4725f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/dc4cf3ea2ffff2a4c30a8a2c395e830ea37dd819
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Georgi-Djakov/iommu-iova-Add-support-for-IOVA-max-alignment-tuning/20211014-021248
        git checkout dc4cf3ea2ffff2a4c30a8a2c395e830ea37dd819
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/iommu/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> drivers/iommu/iova.c:52:13: error: expected parameter declarator
   early_param("iommu.max_align_shift", iommu_set_def_max_align_shift);
               ^
>> drivers/iommu/iova.c:52:13: error: expected ')'
   drivers/iommu/iova.c:52:12: note: to match this '('
   early_param("iommu.max_align_shift", iommu_set_def_max_align_shift);
              ^
>> drivers/iommu/iova.c:52:1: warning: declaration specifier missing, defaulting to 'int'
   early_param("iommu.max_align_shift", iommu_set_def_max_align_shift);
   ^
   int
>> drivers/iommu/iova.c:52:12: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
   early_param("iommu.max_align_shift", iommu_set_def_max_align_shift);
              ^
                                                                     void
   1 warning and 3 errors generated.

vim +52 drivers/iommu/iova.c

    40	
    41	static int __init iommu_set_def_max_align_shift(char *str)
    42	{
    43		unsigned long max_align_shift;
    44	
    45		int ret = kstrtoul(str, 10, &max_align_shift);
    46	
    47		if (!ret)
    48			iommu_max_align_shift = max_align_shift;
    49	
    50		return 0;
    51	}
  > 52	early_param("iommu.max_align_shift", iommu_set_def_max_align_shift);
    53	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36730 bytes --]