From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28A5BC433F5 for ; Thu, 14 Oct 2021 16:10:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10325610A0 for ; Thu, 14 Oct 2021 16:10:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233000AbhJNQNA (ORCPT ); Thu, 14 Oct 2021 12:13:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbhJNQM4 (ORCPT ); Thu, 14 Oct 2021 12:12:56 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5321CC061570 for ; Thu, 14 Oct 2021 09:10:51 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id t184so5016000pfd.0 for ; Thu, 14 Oct 2021 09:10:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BWS52dql+ajKsVGzTwJ00TvBktdComipttyL2oNuCUA=; b=sgo2JFiKekAgFg2ykYeltwB/Fsj+4+LoUN3qyXiTzbhETyJAtuzFRBfn2cZFtCJLYD Ww0LHEKVXCN19dMW27H7oETvQjTySlLeBRTilHKJUTuSaIuBlfHMYQOaVFnEN+sLvqsg vstoadWRFJGTjDUBemqdAGv33z9jm6L2k8jqgsYr8g7m/aDHXEnsYQOP6sVeUCQ5DeYs QuXdv8fdnU4wzib7JjSl5RB+Aow/LCAHkaF6rQXykxcQB56PRh5YuD6ZtReQiOrGnfdy 8lfXufISo8qUCLoHUK/FW9PX2ZuXxWdaChqrAdoDnsBa/960uo8o0hMG2LhjnW0o3QOT q0IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BWS52dql+ajKsVGzTwJ00TvBktdComipttyL2oNuCUA=; b=6WnF+Xr6Ic+NLrlqpnCDPHsvpe6D7d1P98ULfY4qYvD9kM9XZK/To5lC+1AMNsiDlW /LMUeLvbCXsUHIeHaVC3uoMCrUFZOfAqWpm4w98N2ZiMyUFE5QorRHi6kwSqPkBsHoOe jm+tMDvNbBqGJdyHatfOSK6WwT1tg8BeO3inuNwuXvm/jVSsIO1j3Z6lQx2rC9KfhhGe glv4Tu3MhQVPuVAhtvda1N93+Xvv3ikfq4pbojdujeV+eevkBvMpRKVoxrpk7faRoWTm +vO7kdPbBsGdGMTRAptiEsv3ub8mXFly1h9E3iiHTxY1fd3LzZJAARilDAb/2iRPOefa NTpw== X-Gm-Message-State: AOAM530xAU3lb8v+MORsIDuHFZNLBJeGDbtWbu5KNu0cOgg4mbky043J 4hI/GzDm8OVS9rY0rEO8uyANWQ== X-Google-Smtp-Source: ABdhPJzpYqMNKRQchBTM3b76cveOWAI9PjBSkypDO3jKlwMXS3Yau7rxWQtIpFXM7PNYB5zfArVjjw== X-Received: by 2002:a63:1d10:: with SMTP id d16mr4805233pgd.13.1634227850721; Thu, 14 Oct 2021 09:10:50 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id d19sm2843113pfn.102.2021.10.14.09.10.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 09:10:48 -0700 (PDT) Date: Thu, 14 Oct 2021 10:10:46 -0600 From: Mathieu Poirier To: Arnd Bergmann Cc: Ohad Ben-Cohen , Bjorn Andersson , Shawn Guo , Sascha Hauer , Shengjiu Wang , Arnd Bergmann , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc: imx_dsp_rproc: mark PM functions as __maybe_unused Message-ID: <20211014161046.GA2847733@p14s> References: <20211014075239.3714694-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211014075239.3714694-1-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 14, 2021 at 09:52:24AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_PM_SLEEP is disabled, we get a harmless warning: > > drivers/remoteproc/imx_dsp_rproc.c:1145:12: error: 'imx_dsp_resume' defined but not used [-Werror=unused-function] > 1145 | static int imx_dsp_resume(struct device *dev) > | ^~~~~~~~~~~~~~ > drivers/remoteproc/imx_dsp_rproc.c:1110:12: error: 'imx_dsp_suspend' defined but not used [-Werror=unused-function] > 1110 | static int imx_dsp_suspend(struct device *dev) > | ^~~~~~~~~~~~~~~ > > Mark these as __maybe_unused to get a clean build. > > Fixes: ec0e5549f358 ("remoteproc: imx_dsp_rproc: Add remoteproc driver for DSP on i.MX") > Signed-off-by: Arnd Bergmann > --- > drivers/remoteproc/imx_dsp_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I have applied this. Thanks, Mathieu > > diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c > index 63749cfcf22f..90fcb389e252 100644 > --- a/drivers/remoteproc/imx_dsp_rproc.c > +++ b/drivers/remoteproc/imx_dsp_rproc.c > @@ -1107,7 +1107,7 @@ static void imx_dsp_load_firmware(const struct firmware *fw, void *context) > release_firmware(fw); > } > > -static int imx_dsp_suspend(struct device *dev) > +static __maybe_unused int imx_dsp_suspend(struct device *dev) > { > struct rproc *rproc = dev_get_drvdata(dev); > struct imx_dsp_rproc *priv = rproc->priv; > @@ -1142,7 +1142,7 @@ static int imx_dsp_suspend(struct device *dev) > return pm_runtime_force_suspend(dev); > } > > -static int imx_dsp_resume(struct device *dev) > +static __maybe_unused int imx_dsp_resume(struct device *dev) > { > struct rproc *rproc = dev_get_drvdata(dev); > int ret = 0; > -- > 2.29.2 >