From: Nathan Lynch <nathanl@linux.ibm.com>
To: devicetree@vger.kernel.org
Cc: robh+dt@kernel.org, frowand.list@gmail.com, linux-kernel@vger.kernel.org
Subject: [PATCH] of: kobj: make of_node_is_(initialized|attached) parameters const
Date: Thu, 14 Oct 2021 12:30:23 -0500 [thread overview]
Message-ID: <20211014173023.2117799-1-nathanl@linux.ibm.com> (raw)
of_node_is_initialized() and of_node_is_attached() don't modify the node
objects passed to them, so those parameters should be const.
Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
---
drivers/of/kobj.c | 4 ++--
drivers/of/of_private.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/of/kobj.c b/drivers/of/kobj.c
index 6675b5e56960..7d3853a5a09a 100644
--- a/drivers/of/kobj.c
+++ b/drivers/of/kobj.c
@@ -5,13 +5,13 @@
#include "of_private.h"
/* true when node is initialized */
-static int of_node_is_initialized(struct device_node *node)
+static int of_node_is_initialized(const struct device_node *node)
{
return node && node->kobj.state_initialized;
}
/* true when node is attached (i.e. present on sysfs) */
-int of_node_is_attached(struct device_node *node)
+int of_node_is_attached(const struct device_node *node)
{
return node && node->kobj.state_in_sysfs;
}
diff --git a/drivers/of/of_private.h b/drivers/of/of_private.h
index 75e67b8bb826..9324483397f6 100644
--- a/drivers/of/of_private.h
+++ b/drivers/of/of_private.h
@@ -60,7 +60,7 @@ static inline int of_property_notify(int action, struct device_node *np,
#endif /* CONFIG_OF_DYNAMIC */
#if defined(CONFIG_OF_KOBJ)
-int of_node_is_attached(struct device_node *node);
+int of_node_is_attached(const struct device_node *node);
int __of_add_property_sysfs(struct device_node *np, struct property *pp);
void __of_remove_property_sysfs(struct device_node *np, struct property *prop);
void __of_update_property_sysfs(struct device_node *np, struct property *newprop,
--
2.31.1
next reply other threads:[~2021-10-14 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 17:30 Nathan Lynch [this message]
2021-10-20 16:29 ` [PATCH] of: kobj: make of_node_is_(initialized|attached) parameters const Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014173023.2117799-1-nathanl@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).