From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] staging: r8188eu: Use completions instead of semaphores
Date: Sat, 16 Oct 2021 10:12:01 +0300 [thread overview]
Message-ID: <20211016071201.GU8429@kadam> (raw)
In-Reply-To: <2097763.mHcV3lrXRZ@localhost.localdomain>
On Sat, Oct 16, 2021 at 08:43:32AM +0200, Fabio M. De Francesco wrote:
> 2) The second semaphore came to my attention while working on the first and
> trying to understand what rtw_cmd_thread() is meant for. It is there for very
> different reasons. There is only one relation between them, that is that they
> are used into the same function. Nothing else.
>
> So I prefer to write a second commit message (in patch 2/3) that explains
> what the semaphore does and why it is better to replace it with a condition
> variable. Obviously, this "why are you changing it?" has a different answer
> with respect of what I say in patch 1/3.
>
I don't think you're correct, but I will wait for you patch and look
again.
regards,
dan carpenter
next prev parent reply other threads:[~2021-10-16 7:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 11:02 [RFC PATCH] staging: r8188eu: Use completions instead of semaphores Fabio M. De Francesco
2021-10-15 11:37 ` Dan Carpenter
2021-10-15 12:11 ` Fabio M. De Francesco
2021-10-15 12:50 ` Dan Carpenter
2021-10-16 6:43 ` Fabio M. De Francesco
2021-10-16 7:12 ` Dan Carpenter [this message]
2021-10-15 17:52 ` Phillip Potter
2021-10-16 6:59 ` Fabio M. De Francesco
2021-10-16 14:33 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211016071201.GU8429@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).