From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: cpcap-pwrbutton - do not set input parent explicitly
Date: Sat, 16 Oct 2021 18:03:22 +0200 [thread overview]
Message-ID: <20211016160322.4mtmueo2psn7ptrs@earth.universe> (raw)
In-Reply-To: <YWpiZqrfC9+GQsM4@google.com>
[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]
Hi,
On Fri, Oct 15, 2021 at 10:25:58PM -0700, Dmitry Torokhov wrote:
> We are using devm_input_allocate_device() that already sets parent
> of the input device, there is no need to do that again.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> drivers/input/misc/cpcap-pwrbutton.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/cpcap-pwrbutton.c b/drivers/input/misc/cpcap-pwrbutton.c
> index 372cb44d0635..879790bbf9fe 100644
> --- a/drivers/input/misc/cpcap-pwrbutton.c
> +++ b/drivers/input/misc/cpcap-pwrbutton.c
> @@ -77,7 +77,6 @@ static int cpcap_power_button_probe(struct platform_device *pdev)
>
> button->idev->name = "cpcap-pwrbutton";
> button->idev->phys = "cpcap-pwrbutton/input0";
> - button->idev->dev.parent = button->dev;
> input_set_capability(button->idev, EV_KEY, KEY_POWER);
>
> err = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> --
> 2.33.0.1079.g6e70778dc9-goog
>
>
> --
> Dmitry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-10-16 16:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 5:25 [PATCH] Input: cpcap-pwrbutton - do not set input parent explicitly Dmitry Torokhov
2021-10-16 16:03 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211016160322.4mtmueo2psn7ptrs@earth.universe \
--to=sebastian.reichel@collabora.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).