From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Zhang Changzhong <zhangchangzhong@huawei.com>
Cc: Robin van der Gracht <robin@protonic.nl>,
Oleksij Rempel <linux@rempel-privat.de>,
kernel@pengutronix.de, Oliver Hartkopp <socketcan@hartkopp.net>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>,
Maxime Jayat <maxime.jayat@mobile-devices.fr>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] can: j1939: j1939_xtp_rx_rts_session_new(): abort TP less than 9 bytes
Date: Sun, 17 Oct 2021 12:37:08 +0200 [thread overview]
Message-ID: <20211017103708.bzygs6hccnwpjyrp@pengutronix.de> (raw)
In-Reply-To: <1634203601-3460-1-git-send-email-zhangchangzhong@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]
On 14.10.2021 17:26:40, Zhang Changzhong wrote:
> The receiver should abort TP if 'total message size' in TP.CM_RTS and
> TP.CM_BAM is less than 9 or greater than 1785 [1], but currently the
> j1939 stack only checks the upper bound and the receiver will accept the
> following broadcast message:
> vcan1 18ECFF00 [8] 20 08 00 02 FF 00 23 01
> vcan1 18EBFF00 [8] 01 00 00 00 00 00 00 00
> vcan1 18EBFF00 [8] 02 00 FF FF FF FF FF FF
>
> This patch adds check for the lower bound and abort illegal TP.
>
> [1] SAE-J1939-82 A.3.4 Row 2 and A.3.6 Row 6.
>
> Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Applied to linux-can/testing, added stable on Cc.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-10-17 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 9:26 [PATCH net] can: j1939: j1939_xtp_rx_rts_session_new(): abort TP less than 9 bytes Zhang Changzhong
2021-10-14 12:14 ` Oleksij Rempel
2021-10-17 10:37 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211017103708.bzygs6hccnwpjyrp@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=dev.kurt@vandijck-laurijssen.be \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=maxime.jayat@mobile-devices.fr \
--cc=netdev@vger.kernel.org \
--cc=robin@protonic.nl \
--cc=socketcan@hartkopp.net \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).