linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Clark <james.clark@arm.com>
To: acme@kernel.org, linux-perf-users@vger.kernel.org
Cc: denik@chromium.org, James Clark <james.clark@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] perf inject: Add vmlinux and ignore-vmlinux arguments
Date: Mon, 18 Oct 2021 14:48:40 +0100	[thread overview]
Message-ID: <20211018134844.2627174-1-james.clark@arm.com> (raw)

Perf inject was missing the --vmlinux argument so I've added it. At
the same time I tidied up the argument checking that already existed in
perf report and applied it to all tools.

What I'm not sure about is whether it would have been better
to check the accessibility of these files further down in a common place?
It seems like vmlinux_name is also used for a non user provided name at
some point so maybe this would be more complicated than just applying the
existing check everywhere.

Thanks
James

James Clark (3):
  perf tools: Refactor out kernel symbol argument sanity checking
  perf tools: Check vmlinux/kallsyms arguments in all tools
  perf inject: Add vmlinux and ignore-vmlinux arguments

 tools/perf/builtin-annotate.c |  4 ++++
 tools/perf/builtin-c2c.c      |  4 ++++
 tools/perf/builtin-inject.c   |  7 +++++++
 tools/perf/builtin-probe.c    |  5 +++++
 tools/perf/builtin-record.c   |  4 ++++
 tools/perf/builtin-report.c   | 13 ++-----------
 tools/perf/builtin-sched.c    |  4 ++++
 tools/perf/builtin-script.c   |  3 +++
 tools/perf/builtin-top.c      |  4 ++++
 tools/perf/util/symbol.c      | 22 ++++++++++++++++++++++
 tools/perf/util/symbol.h      |  2 ++
 11 files changed, 61 insertions(+), 11 deletions(-)

-- 
2.28.0


             reply	other threads:[~2021-10-18 13:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18 13:48 James Clark [this message]
2021-10-18 13:48 ` [PATCH 1/3] perf tools: Refactor out kernel symbol argument sanity checking James Clark
2021-11-06  1:40   ` Denis Nikitin
2021-10-18 13:48 ` [PATCH 2/3] perf tools: Check vmlinux/kallsyms arguments in all tools James Clark
2021-10-18 13:48 ` [PATCH 3/3] perf inject: Add vmlinux and ignore-vmlinux arguments James Clark
2021-11-06  4:19   ` Denis Nikitin
2021-11-06 19:53     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211018134844.2627174-1-james.clark@arm.com \
    --to=james.clark@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=denik@chromium.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).