From: Christoph Hellwig <hch@lst.de>
To: Coly Li <colyli@suse.de>
Cc: Arnd Bergmann <arnd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Jens Axboe <axboe@kernel.dk>, Kent Overstreet <kmo@daterainc.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] [v2] bcache: hide variable-sized types from uapi header check
Date: Mon, 18 Oct 2021 17:22:24 +0200 [thread overview]
Message-ID: <20211018152224.GB31195@lst.de> (raw)
In-Reply-To: <12a593bc-68bc-ac03-0307-a65a0c064af3@suse.de>
On Mon, Oct 18, 2021 at 10:42:37PM +0800, Coly Li wrote:
> I am quite open for this idea. It is in uapi directory before I maintain
> bcache. I just though the header fines on-media format should go into
> include/uapi/, but if this is not the restricted rule, it is fine for me to
> move this header to drivers/md/bcache/.
Treating the on-disk definitions as a UAPI doesn't make much sense to
me. I like keeping it in a separate header to make clear what is the
on-disk format and what is just in core, but it should normally live
with the rest of the code.
next prev parent reply other threads:[~2021-10-18 15:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 8:55 [PATCH] [v2] bcache: hide variable-sized types from uapi header check Arnd Bergmann
2021-10-18 14:20 ` Coly Li
2021-10-18 14:39 ` Arnd Bergmann
2021-10-18 14:42 ` Coly Li
2021-10-18 15:18 ` Christoph Hellwig
2021-10-18 15:22 ` Christoph Hellwig [this message]
2021-10-18 15:26 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211018152224.GB31195@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).