Re: [PATCH v3 0/3] PCI/MSI: Clarify the IRQ sysfs ABI for PCI devices

From: Bjorn Helgaas <helgaas@kernel.org>
To: Barry Song <21cnbao@gmail.com>
Cc: bhelgaas@google.com, maz@kernel.org, tglx@linutronix.de,
	Jonathan.Cameron@huawei.com, bilbao@vt.edu, corbet@lwn.net,
	gregkh@linuxfoundation.org, leon@kernel.org,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linuxarm@huawei.com, luzmaximilian@gmail.com,
	mchehab+huawei@kernel.org, schnelle@linux.ibm.com,
	jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
	intel-wired-lan@lists.osuosl.org,
	Barry Song <song.bao.hua@hisilicon.com>
Subject: Re: [PATCH v3 0/3] PCI/MSI: Clarify the IRQ sysfs ABI for PCI devices
Date: Mon, 18 Oct 2021 16:50:47 -0500	[thread overview]
Message-ID: <20211018215047.GA2265015@bhelgaas> (raw)
In-Reply-To: <20210825102636.52757-1-21cnbao@gmail.com>

On Wed, Aug 25, 2021 at 06:26:33PM +0800, Barry Song wrote:
> From: Barry Song <song.bao.hua@hisilicon.com>
> 
> 
> /sys/bus/pci/devices/.../irq has been there for many years but it has never
> been documented. This patchset is trying to clarify it.
> 
> -v3:
>   - Don't attempt to modify the current behaviour of IRQ ABI for MSI-X
>   - Make MSI IRQ ABI more explicit(return 1st IRQ of the IRQ vector)
>   - Add Marc's patch of removing default_irq from the previous comment to
>     the series.
>   Note patch 3/3 indirectly changed the code of pci_restore_msi_state(),
>   drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c is the only driver
>   calling this API. I would appreciate testing done from this driver's
>   maintainers.
> 
> -v2:
>   - split into two patches according to Bjorn's comments;
>   - Add Greg's Acked-by, thanks for reviewing!
>   https://lore.kernel.org/lkml/20210820223744.8439-1-21cnbao@gmail.com/
> 
> -v1:
>   https://lore.kernel.org/lkml/20210813122650.25764-1-21cnbao@gmail.com/#t
> 
> Barry Song (2):
>   Documentation: ABI: sysfs-bus-pci: Add description for IRQ entry
>   PCI/sysfs: Don't depend on pci_dev.irq for IRQ entry

I applied the first two (above) to pci/msi for v5.16, thanks!

As far as I can tell from the discussion so far, they should be safe
and should preserve all existing behavior.  The second patch should
remove the sysfs dependency on the PCI core to swap the INTx and first
MSI IRQ values in dev->irq.

Marc's patch below is certainly desirable but my understanding is that
it requires some driver updates first.

> Marc Zyngier (1):
>   PCI/MSI: remove msi_attrib.default_irq in msi_desc
> 
>  Documentation/ABI/testing/sysfs-bus-pci | 10 ++++++++++
>  drivers/pci/msi.c                       | 12 +++++-------
>  drivers/pci/pci-sysfs.c                 | 23 ++++++++++++++++++++++-
>  include/linux/msi.h                     |  2 --
>  4 files changed, 37 insertions(+), 10 deletions(-)
> 
> -- 
> 1.8.3.1
> 