From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABD4DC433F5 for ; Wed, 20 Oct 2021 07:23:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93BE36115A for ; Wed, 20 Oct 2021 07:23:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229846AbhJTH0M (ORCPT ); Wed, 20 Oct 2021 03:26:12 -0400 Received: from first.geanix.com ([116.203.34.67]:37382 "EHLO first.geanix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230070AbhJTH0J (ORCPT ); Wed, 20 Oct 2021 03:26:09 -0400 Received: from skn-laptop (unknown [185.233.254.173]) by first.geanix.com (Postfix) with ESMTPSA id 831C1C7E64; Wed, 20 Oct 2021 07:23:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=geanix.com; s=first; t=1634714633; bh=0fOWElFyi9S8CRUIgE+h4zZ2mGvEzLj6N86KS3DiB/8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Il8ZPG8eyyLejQX+QKApPZoXan+T7mBumIEfY/TgOZQqY64VM15HsJPZIt/a7WAMq aUD0FasIY+BzK/hOMvx/5JaUuhqf7h4SC1LAGkaSCLrdOcNVA6++pc0ThwB0o/Q4Pv gG6QHGr8eHa3VdcFslwiMESihf7DTuE+Q/II/OyfimAr5nONILXL4fO9c2eNjfpQWQ q6cNJnJHufcHDDBGRaADKUOD/QmGEciU0OB4Lm1A8cWGzlbAPrDuYomN74N/f4erDX Jr8XPTYwiq92VqC+lhnupdpelsuZQOUEpG3m7hU0zIS37L5E6rm/7FHFg3/1Blb8uW 9RrPa5ARJmEhg== Date: Wed, 20 Oct 2021 09:23:52 +0200 From: Sean Nyekjaer To: Miquel Raynal Cc: Boris Brezillon , Richard Weinberger , Vignesh Raghavendra , Boris Brezillon , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] mtd: core: protect access to mtd devices while in suspend Message-ID: <20211020072352.7fnano7wm5l4bfi6@skn-laptop> References: <20211011115253.38497-1-sean@geanix.com> <20211011160546.707b737b@collabora.com> <20211015082206.244a2316@xps13> <20211019180800.3v7emokse6lkpjvk@skn-laptop> <20211020085250.030ef244@collabora.com> <20211020090058.58af1087@collabora.com> <20211020091228.136fde6e@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211020091228.136fde6e@xps13> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 20, 2021 at 09:12:28AM +0200, Miquel Raynal wrote: > > > > Actually, this version is even cleaner: > > > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > > index 3d6c6e880520..98c39b7f6279 100644 > > --- a/drivers/mtd/nand/raw/nand_base.c > > +++ b/drivers/mtd/nand/raw/nand_base.c > > @@ -6222,8 +6222,6 @@ static int nand_scan_tail(struct nand_chip *chip) > > mtd->_sync = nand_sync; > > mtd->_lock = nand_lock; > > mtd->_unlock = nand_unlock; > > - mtd->_suspend = nand_suspend; > > - mtd->_resume = nand_resume; > > mtd->_reboot = nand_shutdown; > > mtd->_block_isreserved = nand_block_isreserved; > > mtd->_block_isbad = nand_block_isbad; > > @@ -6261,14 +6259,20 @@ static int nand_scan_tail(struct nand_chip *chip) > > goto err_free_interface_config; > > > > /* Check, if we should skip the bad block table scan */ > > - if (chip->options & NAND_SKIP_BBTSCAN) > > - return 0; > > - > > - /* Build bad block table */ > > - ret = nand_create_bbt(chip); > > - if (ret) > > - goto err_free_secure_regions; > > + if (chip->options & NAND_SKIP_BBTSCAN) { > > + /* Build bad block table */ > > + ret = nand_create_bbt(chip); > > + if (ret) > > + goto err_free_secure_regions; > > + } > > Nice idea. > > > > > + /* > > + * Populate the suspend/resume hooks after the BBT has been scanned to > > + * avoid using the suspend lock and resume waitqueue which are only > > + * initialized when mtd_device_register() is called. > > + */ > > + mtd->_suspend = nand_suspend; > > + mtd->_resume = nand_resume; > > return 0; > > > > err_free_secure_regions: Could be a nice idea, but it doesn't work... gpmi-nand.c calls nand_create_bbt() after this have run ;) /Sean