From: Steven Rostedt <rostedt@goodmis.org>
To: Kalesh Singh <kaleshsingh@google.com>
Cc: Suren Baghdasaryan <surenb@google.com>,
Hridya Valsaraju <hridya@google.com>,
Namhyung Kim <namhyung@kernel.org>,
"Cc: Android Kernel" <kernel-team@android.com>,
Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Tom Zanussi <zanussi@kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] tracing: Fix operator precedence for hist triggers expression
Date: Wed, 20 Oct 2021 12:19:08 -0400 [thread overview]
Message-ID: <20211020121908.28fed7af@gandalf.local.home> (raw)
In-Reply-To: <CAC_TJvfsF9BF2wfGck1icX_Ya7dLWO+hOBA5cR56PPr0Dn9D9Q@mail.gmail.com>
On Wed, 20 Oct 2021 09:11:27 -0700
Kalesh Singh <kaleshsingh@google.com> wrote:
> The main reason for this is that it's predictable behavior form the
> user's perspective. Before this patch the recursion always walked down
> a single branch so limiting by level worked out the same as limiting
> by sub expressions and is in line with the error the user would see
> ("Too many sub-expressions (3 max)"). Now that we take multiple paths
> in the recursion, using the level to reflect the number of
> sub-expressions would lead to only seeing the error in some of the
> cases (Sometimes we allow 4, 5, 6 sub-expressions depending on how
> balanced the tree is, and sometimes we error out on 4 - when the tree
> is list-like). Limiting by sub-expression keeps this consistent
> (always error out if we have more than 3 sub-expressions) and is in
> line with the previous behavior.
I'm fine with that. If we want to improve this in the future then fine. We
can always extend, as that doesn't break user API.
So we can keep it as is.
-- Steve
next prev parent reply other threads:[~2021-10-20 16:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 1:31 [PATCH v2 0/5] tracing: Extend histogram triggers expression parsing Kalesh Singh
2021-10-20 1:31 ` [PATCH v2 1/5] tracing: Add support for creating hist trigger variables from literal Kalesh Singh
2021-10-20 15:32 ` Steven Rostedt
2021-10-20 15:55 ` Kalesh Singh
2021-10-20 15:59 ` Steven Rostedt
2021-10-20 1:31 ` [PATCH v2 2/5] tracing: Add division and multiplication support for hist triggers Kalesh Singh
2021-10-20 2:27 ` Steven Rostedt
2021-10-20 14:54 ` Kalesh Singh
2021-10-20 15:13 ` Steven Rostedt
2021-10-20 15:23 ` Kalesh Singh
2021-10-20 1:31 ` [PATCH v2 3/5] tracing: Fix operator precedence for hist triggers expression Kalesh Singh
2021-10-20 14:28 ` Steven Rostedt
2021-10-20 15:06 ` Kalesh Singh
2021-10-20 15:13 ` Steven Rostedt
2021-10-20 15:48 ` Steven Rostedt
2021-10-20 16:11 ` Kalesh Singh
2021-10-20 16:19 ` Steven Rostedt [this message]
2021-10-20 16:22 ` Kalesh Singh
2021-10-20 1:31 ` [PATCH v2 4/5] tracing/selftests: Add tests for hist trigger expression parsing Kalesh Singh
2021-10-20 1:31 ` [PATCH v2 5/5] tracing/histogram: Document expression arithmetic and constants Kalesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020121908.28fed7af@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=corbet@lwn.net \
--cc=hridya@google.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).