From: Uladzislau Rezki <urezki@gmail.com>
To: Michal Hocko <mhocko@suse.com>
Cc: Michal Hocko <mhocko@suse.com>,
Linux Memory Management List <linux-mm@kvack.org>,
Dave Chinner <david@fromorbit.com>, Neil Brown <neilb@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
Jeff Layton <jlayton@kernel.org>
Subject: Re: [RFC 2/3] mm/vmalloc: add support for __GFP_NOFAIL
Date: Wed, 20 Oct 2021 21:24:30 +0200 [thread overview]
Message-ID: <20211020192430.GA1861@pc638.lan> (raw)
In-Reply-To: <CA+KHdyVdrfLPNJESEYzxfF+bksFpKGCd8vH=NqdwfPOLV9ZO8Q@mail.gmail.com>
On Wed, Oct 20, 2021 at 05:00:28PM +0200, Uladzislau Rezki wrote:
> >
> > On Wed 20-10-21 16:29:14, Uladzislau Rezki wrote:
> > > On Wed, Oct 20, 2021 at 4:06 PM Michal Hocko <mhocko@suse.com> wrote:
> > [...]
> > > > As I've said I am OK with either of the two. Do you or anybody have any
> > > > preference? Without any explicit event to wake up for neither of the two
> > > > is more than just an optimistic retry.
> > > >
> > > From power perspective it is better to have a delay, so i tend to say
> > > that delay is better.
> >
> > I am a terrible random number generator. Can you give me a number
> > please?
> >
> Well, we can start from one jiffy so it is one timer tick: schedule_timeout(1)
>
A small nit, it is better to replace it by the simple msleep() call: msleep(jiffies_to_msecs(1));
--
Vlad Rezki
next prev parent reply other threads:[~2021-10-20 19:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 11:47 [RFC 0/3] extend vmalloc support for constrained allocations Michal Hocko
2021-10-18 11:47 ` [RFC 1/3] mm/vmalloc: alloc GFP_NO{FS,IO} for vmalloc Michal Hocko
2021-10-19 0:44 ` NeilBrown
2021-10-19 6:59 ` Michal Hocko
2021-10-18 11:47 ` [RFC 2/3] mm/vmalloc: add support for __GFP_NOFAIL Michal Hocko
2021-10-18 16:48 ` Michal Hocko
2021-10-19 11:06 ` Uladzislau Rezki
2021-10-19 11:52 ` Michal Hocko
2021-10-19 19:46 ` Uladzislau Rezki
2021-10-20 8:25 ` Michal Hocko
2021-10-20 9:18 ` Michal Hocko
2021-10-20 13:54 ` Uladzislau Rezki
2021-10-20 14:06 ` Michal Hocko
2021-10-20 14:29 ` Uladzislau Rezki
2021-10-20 14:53 ` Michal Hocko
2021-10-20 15:00 ` Uladzislau Rezki
2021-10-20 19:24 ` Uladzislau Rezki [this message]
2021-10-21 8:56 ` Michal Hocko
2021-10-21 10:13 ` NeilBrown
2021-10-21 10:27 ` Michal Hocko
2021-10-21 10:40 ` Uladzislau Rezki
2021-10-21 22:49 ` NeilBrown
2021-10-22 8:18 ` Michal Hocko
2021-10-25 9:48 ` Uladzislau Rezki
2021-10-25 11:20 ` Michal Hocko
2021-10-25 14:30 ` Uladzislau Rezki
2021-10-25 14:56 ` Michal Hocko
2021-10-25 23:50 ` NeilBrown
2021-10-26 7:16 ` Michal Hocko
2021-10-26 10:24 ` NeilBrown
2021-10-26 14:25 ` Uladzislau Rezki
2021-10-26 14:43 ` Michal Hocko
2021-10-26 15:40 ` Uladzislau Rezki
2021-10-20 8:25 ` [PATCH] mm/vmalloc: be more explicit about supported gfp flags Michal Hocko
2021-10-18 11:47 ` [RFC 3/3] mm: allow !GFP_KERNEL allocations for kvmalloc Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020192430.GA1861@pc638.lan \
--to=urezki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).