From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25522C4332F for ; Thu, 21 Oct 2021 00:24:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E698613A0 for ; Thu, 21 Oct 2021 00:24:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232180AbhJUA02 (ORCPT ); Wed, 20 Oct 2021 20:26:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:44862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231445AbhJUAZb (ORCPT ); Wed, 20 Oct 2021 20:25:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 22CE561215; Thu, 21 Oct 2021 00:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634775795; bh=dvmS/3+wKffXFp5H4Wbw2bRep6wqx8nbVPuPvQXFW3w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NyzLxnNd5xkc0CLHpzpWI0JxEw7YboCbcmzCqKd7RnN3crtCF8b8O9Vnpw7VSFsLm AffzGahEjXhdXWqGAshs0wiOT3v2l0NIvk6/m9ET5fM/9fB5jBxpS6Yi48ioskDBge pY0sr0TazGGHJWgUoRXtdGibiAlLMCqtGxDLZwD9NEOvGOum3ndP+Nnxn9GebnNzYS SsL6z8bqMSRgXNO+nvkR4zIhl7BmeOUzfIiYus7PBt4rDTgzRpbJdiG8D4LWkQiHsd 9pt4vuN3I4WNC68Cm2oyDsYWFsPp2m76umXGZbP65dlLpTh3EACf2mjt1qodUmqIJv znMlsgHrMPMLg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Lin Ma , Krzysztof Kozlowski , "David S . Miller" , Sasha Levin , kuba@kernel.org, bongsu.jeon@samsung.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 05/10] nfc: nci: fix the UAF of rf_conn_info object Date: Wed, 20 Oct 2021 20:23:00 -0400 Message-Id: <20211021002305.1129633-5-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211021002305.1129633-1-sashal@kernel.org> References: <20211021002305.1129633-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lin Ma [ Upstream commit 1b1499a817c90fd1ce9453a2c98d2a01cca0e775 ] The nci_core_conn_close_rsp_packet() function will release the conn_info with given conn_id. However, it needs to set the rf_conn_info to NULL to prevent other routines like nci_rf_intf_activated_ntf_packet() to trigger the UAF. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Lin Ma Signed-off-by: Krzysztof Kozlowski Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/nfc/nci/rsp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/nfc/nci/rsp.c b/net/nfc/nci/rsp.c index e3bbf1937d0e..7681f89dc312 100644 --- a/net/nfc/nci/rsp.c +++ b/net/nfc/nci/rsp.c @@ -289,6 +289,8 @@ static void nci_core_conn_close_rsp_packet(struct nci_dev *ndev, ndev->cur_conn_id); if (conn_info) { list_del(&conn_info->list); + if (conn_info == ndev->rf_conn_info) + ndev->rf_conn_info = NULL; devm_kfree(&ndev->nfc_dev->dev, conn_info); } } -- 2.33.0