From: Lukas Wunner <lukas@wunner.de>
To: Naveen Naidu <naveennaidu479@gmail.com>
Cc: bhelgaas@google.com,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Amey Narkhede <ameynarkhede03@gmail.com>
Subject: Re: [PATCH v3 18/25] PCI: pciehp: Use RESPONSE_IS_PCI_ERROR() to check read from hardware
Date: Fri, 22 Oct 2021 09:01:48 +0200 [thread overview]
Message-ID: <20211022070148.GB17656@wunner.de> (raw)
In-Reply-To: <20211021152253.pqc6xp3vnv5fpczj@theprophet>
On Thu, Oct 21, 2021 at 08:52:53PM +0530, Naveen Naidu wrote:
> Lukas, I have not added your Acked-by tag from the v1 [1] of the patch
> series, since the RESPONSE_IS_PCI_ERROR macro definition slightly
> changed. I hope this was the right thing to do.
[...]
> If that is not the case please let me know. But I am not sure what to
> do here? If RESPONSE_IS_PCI_ERROR does not fit here, should the right
> option would be to revert/remove this patch from the series?
My Acked-by still stands. As for the macro name, I'm fine with
whatever Bjorn and the community settle on. :)
Thanks,
Lukas
next prev parent reply other threads:[~2021-10-22 7:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 15:07 [PATCH v3 00/25] Unify PCI error response checking Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 01/25] PCI: Add PCI_ERROR_RESPONSE and it's related definitions Naveen Naidu
2021-10-21 16:08 ` Pali Rohár
2021-11-17 23:58 ` Bjorn Helgaas
2021-11-18 13:30 ` Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 02/25] PCI: Set error response in config access defines when ops->read() fails Naveen Naidu
2021-10-21 15:59 ` Pali Rohár
2021-10-21 15:07 ` [PATCH v3 03/25] PCI: Use SET_PCI_ERROR_RESPONSE() when device not found Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 04/25] PCI: Remove redundant error fabrication when device read fails Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 05/25] PCI: thunder: " Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 06/25] PCI: iproc: " Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 07/25] PCI: mediatek: " Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 08/25] PCI: exynos: " Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 09/25] PCI: histb: " Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 10/25] PCI: kirin: " Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 11/25] PCI: aardvark: " Naveen Naidu
2021-10-21 15:58 ` Pali Rohár
2021-10-21 15:07 ` [PATCH v3 12/25] PCI: mvebu: " Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 13/25] PCI: altera: " Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 14/25] PCI: rcar: " Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 15/25] PCI: rockchip: " Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 16/25] PCI/ERR: Use RESPONSE_IS_PCI_ERROR() to check read from hardware Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 17/25] PCI: vmd: " Naveen Naidu
2021-10-21 15:19 ` Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 18/25] PCI: pciehp: " Naveen Naidu
2021-10-21 15:22 ` Naveen Naidu
2021-10-22 7:01 ` Lukas Wunner [this message]
2021-10-21 15:07 ` [PATCH v3 19/25] PCI/DPC: " Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 20/25] PCI/PME: " Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 21/25] PCI: cpqphp: " Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 22/25] PCI: Use PCI_ERROR_RESPONSE to specify hardware error Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 23/25] PCI: keystone: " Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 24/25] PCI: hv: Use PCI_ERROR_RESPONSE to specify hardware read error Naveen Naidu
2021-10-21 15:07 ` [PATCH v3 25/25] PCI: xgene: Use PCI_ERROR_RESPONSE to specify hardware error Naveen Naidu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211022070148.GB17656@wunner.de \
--to=lukas@wunner.de \
--cc=ameynarkhede03@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=naveennaidu479@gmail.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).