From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 182F8C433FE for ; Fri, 22 Oct 2021 16:25:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F01B4610EA for ; Fri, 22 Oct 2021 16:25:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233406AbhJVQ16 (ORCPT ); Fri, 22 Oct 2021 12:27:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231651AbhJVQ15 (ORCPT ); Fri, 22 Oct 2021 12:27:57 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6E6AC061766 for ; Fri, 22 Oct 2021 09:25:39 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id f11so4074841pfc.12 for ; Fri, 22 Oct 2021 09:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oY8QSYkniGy4foDwgoWYdCetbab1zPbJRB3YWoKstsE=; b=MUWNx3ydXkRZ7nB7ArzoWGGeu6JqXj7Ky5ZfIDscQDuCMzNfx+xgFPGBWy+zDWUY47 3PYKPYxfkr0ddwz1kNVl+ytmt7rTBfCSOspw/QU3EuapopAnO+fibI4sj+///UjF2JdW lJnBm1GFhR2UhelUXjKKZzhsgkVqsnJB3pKF0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oY8QSYkniGy4foDwgoWYdCetbab1zPbJRB3YWoKstsE=; b=CobExNSolJr8x+7/XHHiwgGvNpmriCD9FaYTurOQv1R1+IsOvJZ+HoiYV+KlS+CRfX ujQK/lPrR5JC03KueTJKJBxN137qZl5OYUqM9x1SW9OXgWBXdoODvqH1myZyWUbADEqB CddACmY0iqCi3TPOAwOepPkLgBSocOqeT/QgAs5QZPvBAVqsPB0oE9895p8EKbSxtNCz a+gUFO5TQSyoyOhD7E4JsXPHgAJ5J90lhLuk3Dwm/iqUqxjZV+lCTpXRWyV79j5oUpQb 6kdSNPdfNY5ME1Xfv82IsdLnxbsoj8j+2JTHAQE4boPoX9AeR4cGDqOelzLnjMRizdLL hnog== X-Gm-Message-State: AOAM533LNSzZMLhDzDwdsaAqwgUSCdplwcmpGSWDxy5c4gSr2lmgFNe2 qtcIjdHWiZ47nZZBS81rE4VY7Q== X-Google-Smtp-Source: ABdhPJwuLhj8Lhk+PvZk4Vj66qz3fpKXwmJq6CzRpEAOw69JTAOqJlloI73LhZpzAFtBIsPB633tEg== X-Received: by 2002:a63:c:: with SMTP id 12mr508399pga.477.1634919939440; Fri, 22 Oct 2021 09:25:39 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id mu7sm11214296pjb.12.2021.10.22.09.25.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Oct 2021 09:25:39 -0700 (PDT) Date: Fri, 22 Oct 2021 09:25:38 -0700 From: Kees Cook To: Peter Zijlstra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, akpm@linux-foundation.org, mark.rutland@arm.com, zhengqi.arch@bytedance.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, paul.walmsley@sifive.com, palmer@dabbelt.com, hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, linux-arch@vger.kernel.org, ardb@kernel.org, Stephen Rothwell Subject: Re: [PATCH 1/7] x86: Fix __get_wchan() for !STACKTRACE Message-ID: <202110220925.C2A17F092@keescook> References: <20211022150933.883959987@infradead.org> <20211022152104.137058575@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211022152104.137058575@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 22, 2021 at 05:09:34PM +0200, Peter Zijlstra wrote: > Use asm/unwind.h to implement wchan, since we cannot always rely on > STACKTRACE=y. > > Reported-by: Stephen Rothwell > Fixes: bc9bbb81730e ("x86: Fix get_wchan() to support the ORC unwinder") > Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Kees Cook -- Kees Cook