From: Bryan Brattlof <hello@bryanbrattlof.com>
To: Kushal Kothari <kushalkothari285@gmail.com>
Cc: gregkh@linuxfoundation.org, kush19992810@gmail.com,
outreachy-kernel@googlegroups.com, fabioaiuto83@gmail.com,
ross.schm.dev@gmail.com, fmdefrancesco@gmail.com,
marcocesati@gmail.com, straube.linux@gmail.com,
philippesdixon@gmail.com, manuelpalenzuelamerino@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
mike.rapoport@gmail.com, kushalkotharitest@googlegroups.com
Subject: Re: [PATCH v3 1/4] staging: rtl8723bs: core: Remove true and false comparison
Date: Fri, 22 Oct 2021 11:28:12 -0400 [thread overview]
Message-ID: <20211022152812.yv4nicwpzmwggn25@h510> (raw)
In-Reply-To: <7d5df4b8aacd961d0de367cbd73a8b75272652a8.1634906059.git.kushalkothari285@gmail.com>
Hi Kushal,
On this day, October 22, 2021, thus sayeth Kushal Kothari:
> Remove comparison to true and false in if statement.
> Issue found with checkpatch.pl.
> CHECK: Using comparison to true is error prone
> CHECK: Using comparison to false is error prone
>
> Signed-off-by: Kushal Kothari <kushalkothari285@gmail.com>
>
> Changes in v3: Enclose the version number inside the square bracket.
> Changes in v2: Unnecessary parantheses handled in *v2 staging: rtl8723bs: core: Remove unnecessary parentheses*
You may want to move these version notes below the cutoff so they won't
be included in the body of your commit message.
> ---
[here]
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 2624e994513f..acd4e8b1fad5 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -371,7 +371,7 @@ void rtw_free_cmd_obj(struct cmd_obj *pcmd)
~Bryan
next prev parent reply other threads:[~2021-10-22 15:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 13:13 [PATCH v3 0/4] staging: rtl8723bs: core: Cleanup patchset for style issues in rtw_cmd.c Kushal Kothari
2021-10-22 13:13 ` [PATCH v3 1/4] staging: rtl8723bs: core: Remove true and false comparison Kushal Kothari
2021-10-22 15:28 ` Bryan Brattlof [this message]
2021-10-22 15:48 ` [Outreachy kernel] " Alison Schofield
2021-10-22 13:13 ` [PATCH v3 2/4] staging: rtl8723bs: core: Remove unnecessary parentheses Kushal Kothari
2021-10-22 13:13 ` [PATCH v3 3/4] staging: rtl8723bs: core: Remove unnecessary space after a cast Kushal Kothari
2021-10-22 13:13 ` [PATCH v3 4/4] staging: rtl8723bs: core: Remove unnecessary blank lines Kushal Kothari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211022152812.yv4nicwpzmwggn25@h510 \
--to=hello@bryanbrattlof.com \
--cc=fabioaiuto83@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kush19992810@gmail.com \
--cc=kushalkothari285@gmail.com \
--cc=kushalkotharitest@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manuelpalenzuelamerino@gmail.com \
--cc=marcocesati@gmail.com \
--cc=mike.rapoport@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=philippesdixon@gmail.com \
--cc=ross.schm.dev@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).