From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4491DC433EF for ; Mon, 25 Oct 2021 11:45:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 291AD61002 for ; Mon, 25 Oct 2021 11:45:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233010AbhJYLr4 (ORCPT ); Mon, 25 Oct 2021 07:47:56 -0400 Received: from mga09.intel.com ([134.134.136.24]:62204 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230407AbhJYLrw (ORCPT ); Mon, 25 Oct 2021 07:47:52 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10147"; a="229490230" X-IronPort-AV: E=Sophos;i="5.87,180,1631602800"; d="scan'208";a="229490230" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2021 04:45:30 -0700 X-IronPort-AV: E=Sophos;i="5.87,180,1631602800"; d="scan'208";a="496765374" Received: from yifanyao-mobl.ccr.corp.intel.com (HELO chenyu5-mobl1) ([10.249.171.31]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2021 04:45:26 -0700 Date: Mon, 25 Oct 2021 19:45:19 +0800 From: Chen Yu To: Greg Kroah-Hartman Cc: linux-acpi@vger.kernel.org, "Rafael J. Wysocki" , Ard Biesheuvel , Len Brown , Ashok Raj , Andy Shevchenko , Mike Rapoport , Aubrey Li , linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/4] efi: Introduce EFI_FIRMWARE_MANAGEMENT_CAPSULE_HEADER and corresponding structures Message-ID: <20211025114519.GA7559@chenyu5-mobl1> References: <1cd3161bf51de99990fd5ee2dc896b4defef4f38.1635140590.git.yu.c.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 25, 2021 at 08:44:00AM +0200, Greg Kroah-Hartman wrote: > On Mon, Oct 25, 2021 at 02:25:04PM +0800, Chen Yu wrote: > > Platform Firmware Runtime Update image starts with UEFI headers, and the > > headers are defined in UEFI specification, but some of them have not been > > defined in the kernel yet. > > > > For example, the header layout of a capsule file looks like this: > > > > EFI_CAPSULE_HEADER > > EFI_FIRMWARE_MANAGEMENT_CAPSULE_HEADER > > EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER > > EFI_FIRMWARE_IMAGE_AUTHENTICATION > > > > These structures would be used by the Platform Firmware Runtime Update > > driver to parse the format of capsule file to verify if the corresponding > > version number is valid. The EFI_CAPSULE_HEADER has been defined in the > > kernel, however the rest are not, thus introduce corresponding UEFI > > structures accordingly. Besides, EFI_FIRMWARE_MANAGEMENT_CAPSULE_HEADER > > and EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER need not be aligned and > > so the corresponding data types should be packed. > > > > Signed-off-by: Chen Yu > > --- > > v6: No change since v5. > > v5: No change since v4. > > v4: Revise the commit log to make it more clear. (Rafael J. Wysocki) > > --- > > include/linux/efi.h | 50 +++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > > > diff --git a/include/linux/efi.h b/include/linux/efi.h > > index 6b5d36babfcc..19ff834e1388 100644 > > --- a/include/linux/efi.h > > +++ b/include/linux/efi.h > > @@ -148,6 +148,56 @@ typedef struct { > > u32 imagesize; > > } efi_capsule_header_t; > > > > +#pragma pack(1) > > Why is this pragma suddenly needed now in this file? > > If you really need this for a specific structure, use the "__packed" > attribute please. > These two structures are required to be packed in the uefi spec, I'll change them to "__packed". thanks, Chenyu > thanks, > > greg k-h