From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F810C43217 for ; Mon, 25 Oct 2021 19:42:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 045AD613A3 for ; Mon, 25 Oct 2021 19:42:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237626AbhJYToA (ORCPT ); Mon, 25 Oct 2021 15:44:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:53236 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236525AbhJYTgt (ORCPT ); Mon, 25 Oct 2021 15:36:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 12DCE61108; Mon, 25 Oct 2021 19:33:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1635190418; bh=sbWB9pK/RdTgERQKSX/SJQrI2ggIiBKS1cz1sCRFJWk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jXM8gs7FZqTEBEXfVB80qMuTDioom6T+1QWrVKpImBWX7r8EobsF1WlbfSo787C6j RrX2weN3lz7rwrZaerUNjHyi0F1vpcg+GbzzL9dlWgvGDlpmikvTNJHXu2Ojk1+yOw m7lcNQc+orWcNPtw61ikVF2aPfom80LJjaS/KUOw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, kernel test robot , Dan Carpenter , Gaosheng Cui , Paul Moore Subject: [PATCH 5.10 53/95] audit: fix possible null-pointer dereference in audit_filter_rules Date: Mon, 25 Oct 2021 21:14:50 +0200 Message-Id: <20211025191004.266994337@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211025190956.374447057@linuxfoundation.org> References: <20211025190956.374447057@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gaosheng Cui commit 6e3ee990c90494561921c756481d0e2125d8b895 upstream. Fix possible null-pointer dereference in audit_filter_rules. audit_filter_rules() error: we previously assumed 'ctx' could be null Cc: stable@vger.kernel.org Fixes: bf361231c295 ("audit: add saddr_fam filter field") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Gaosheng Cui Signed-off-by: Paul Moore Signed-off-by: Greg Kroah-Hartman --- kernel/auditsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/kernel/auditsc.c +++ b/kernel/auditsc.c @@ -653,7 +653,7 @@ static int audit_filter_rules(struct tas result = audit_comparator(audit_loginuid_set(tsk), f->op, f->val); break; case AUDIT_SADDR_FAM: - if (ctx->sockaddr) + if (ctx && ctx->sockaddr) result = audit_comparator(ctx->sockaddr->ss_family, f->op, f->val); break;