From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14F6DC433EF for ; Tue, 26 Oct 2021 01:13:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB97E60F02 for ; Tue, 26 Oct 2021 01:13:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234668AbhJZBPp (ORCPT ); Mon, 25 Oct 2021 21:15:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233612AbhJZBPn (ORCPT ); Mon, 25 Oct 2021 21:15:43 -0400 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 453E7C061745 for ; Mon, 25 Oct 2021 18:13:20 -0700 (PDT) Received: by mail-qt1-x830.google.com with SMTP id i1so12050037qtr.6 for ; Mon, 25 Oct 2021 18:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zoFDos6hqsoqPNE3Ubon2jXwfOR6C/kTOnroswa4np0=; b=YD76ZQyDKFx2VikMwfx6Wtm4xSipBCQMd/DLWlpZ4zQmxA5Ud/s31RJ4FSUZA77SF5 8VKmNmiXVI1JNvMACnCbxkuTr3kiesrznZiUIdy7f1/20He1Z4WdGTHmqmfkiJdU0eeu 77YLxMrXZ0o4r2X158iw2180hPelIRw6n/OGcKFzn/B0ClULewryvg3Qvv/TqQ0V8hnT FzIbYZrouWQ+nxIHHd/mw6/h/P9Y1JrLkUnzTGWA/8NQLM9GzXcHrwY/UUs18ChJIF3Y PpIfbNQsnbCuVZuSDrfrnt+5d7Eaxjb/cd0XvPKX5ckVFvzboFMgdYvyDa7JsW6NmiyY hoJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zoFDos6hqsoqPNE3Ubon2jXwfOR6C/kTOnroswa4np0=; b=PtGj8w90Obtoq65J2DdFzutE4rqhxVanvHb/2kdQO6qtU6z53I+U9U2lPkyblWPTq0 44ryRijgMzsisuJ2dXQL6pgppC3dwyEy5P9goSODBdktvAAr6jkzQqGMyB94SbP1iN8a atCsHp9EY9pLeIHb8FOZiM5LbPPWdw5oXbRltbbjcbPw+wIwpYuHE7Z8LHBaWbbXuonx PfSsHDjuCGX1HfPHKXunRMkj2c2S/z4LwILlxuz9wpj3yolnESilv1aB7oUBmX64Ofee MZRcR1rYuxgBXVreead0fOv89NUd1gnL4v4s8k2v+xwSmAtTJlMzMO6VJO/uxFQpThZp Jkug== X-Gm-Message-State: AOAM530/UH6EwjjnE/58O5eR6Pt44FXnLZSAjbjw+wpb/zOzJwyzIWuV dkKBH28nIPDTa39+Tmzp0EwAJQ== X-Google-Smtp-Source: ABdhPJwZ4eKoLPCDqP0AOPkjcIy0mJFLBRYWPbATnTT744Z29KzjLAreryt+LTa8sHr0LQ9cUbLj4w== X-Received: by 2002:a05:622a:13:: with SMTP id x19mr21230249qtw.83.1635210799496; Mon, 25 Oct 2021 18:13:19 -0700 (PDT) Received: from localhost ([167.100.64.199]) by smtp.gmail.com with ESMTPSA id bj26sm10232892qkb.127.2021.10.25.18.13.19 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Oct 2021 18:13:19 -0700 (PDT) Date: Mon, 25 Oct 2021 21:13:18 -0400 From: Sean Paul To: Mark Yacoub Cc: linux-mediatek@lists.infradead.org, seanpaul@chromium.org, Mark Yacoub , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mediatek: Set default value for Panel Orientation connector prop. Message-ID: <20211026011318.GF2515@art_vandelay> References: <20211022172413.195559-1-markyacoub@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211022172413.195559-1-markyacoub@chromium.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote: > From: Mark Yacoub > > [Why] > Creating the prop uses UNKNOWN as the initial value, which is not a > supported value if the props is to be supported. > > [How] > Set the panel orientation default value to NORMAL right after creating > the prop. Reviewed-by: Sean Paul > > Tested on Jacuzzi(MTK) > Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic} > > Signed-off-by: Mark Yacoub > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 0ad7157660afa..b7c2528a8f41c 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -1039,6 +1039,8 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) > DRM_ERROR("Unable to init panel orientation\n"); > goto err_cleanup_encoder; > } > + drm_connector_set_panel_orientation(dsi->connector, > + DRM_MODE_PANEL_ORIENTATION_NORMAL); > > drm_connector_attach_encoder(dsi->connector, &dsi->encoder); > > -- > 2.33.0.1079.g6e70778dc9-goog > -- Sean Paul, Software Engineer, Google / Chromium OS