From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>, <mingo@redhat.com>,
<shuah@kernel.org>, <linux-kselftest@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Philip Li <philip.li@intel.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] kselftests: ftrace: limit the executing time by reading from cached trace
Date: Tue, 26 Oct 2021 21:13:31 +0900 [thread overview]
Message-ID: <20211026211331.8496340b0011127e6505b5ff@kernel.org> (raw)
In-Reply-To: <20211025221717.56daf4e8@rorschach.local.home>
On Mon, 25 Oct 2021 22:17:17 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 21 Oct 2021 09:31:31 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > > > +# Stop tracing while reading the trace file by default, to prevent
> > > > +# the test results while checking it and to avoid taking a long time
> > > > +# to check the result.
> > > > + [ -f options/pause-on-trace ] && echo 1 > options/pause-on-trace
> > > > +
> > >
> > > Is there a way we can save the previous setting and put it back on reset?
> >
> > No, since each testcase must be run under the clean state. Would we need to
> > recover the settings?
>
> I would at least put it back to the default. If someone runs the tests,
> it should at least put it back to what it was at boot. Otherwise,
> someone might run the tests, and then wonder why events are being
> dropped when they are reading the trace.
Umm, we may need to have a knob to reset the ftrace options...
Can we warn such user that if the ftracetest finds that the current
value is not the same what it sets?
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-10-26 12:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 13:26 [PATCH] kselftests: ftrace: limit the executing time by reading from cached trace Li Zhijian
2021-10-19 2:16 ` Steven Rostedt
2021-10-20 2:20 ` Masami Hiramatsu
2021-10-20 2:34 ` Steven Rostedt
2021-10-20 2:55 ` Masami Hiramatsu
2021-10-20 4:10 ` lizhijian
2021-10-20 14:16 ` Steven Rostedt
2021-10-21 0:31 ` Masami Hiramatsu
2021-10-26 2:17 ` Steven Rostedt
2021-10-26 12:13 ` Masami Hiramatsu [this message]
2021-10-26 13:15 ` Steven Rostedt
2021-10-26 14:13 ` Masami Hiramatsu
2021-10-26 15:16 ` Steven Rostedt
2021-10-26 23:19 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211026211331.8496340b0011127e6505b5ff@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizhijian@cn.fujitsu.com \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=philip.li@intel.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).