Re: [PATCH v20 2/2] wireless: Initial driver submission for pureLiFi STA devices

From: kernel test robot <lkp@intel.com>
To: Srinivasan Raju <srini.raju@purelifi.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	mostafa.afgani@purelifi.com,
	Srinivasan Raju <srini.raju@purelifi.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	Jakub Kicinski <kuba@kernel.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:NETWORKING DRIVERS (WIRELESS)" 
	<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v20 2/2] wireless: Initial driver submission for pureLiFi STA devices
Date: Wed, 27 Oct 2021 19:34:11 +0800	[thread overview]
Message-ID: <202110271951.CwXdMBph-lkp@intel.com> (raw)
In-Reply-To: <20211018100143.7565-3-srini.raju@purelifi.com>

[-- Attachment #1: Type: text/plain, Size: 4398 bytes --]

Hi Srinivasan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on kvalo-wireless-drivers-next/master]
[also build test WARNING on kvalo-wireless-drivers/master jberg-mac80211/master v5.15-rc7]
[cannot apply to jberg-mac80211-next/master next-20211026]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Srinivasan-Raju/nl80211-Add-LC-placeholder-band-definition-to-nl80211_band/20211018-190152
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: mips-randconfig-r011-20211027 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5db7568a6a1fcb408eb8988abdaff2a225a8eb72)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/0day-ci/linux/commit/ae5d24705bf40b9954a995fd7d768ab4cc879bc2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Srinivasan-Raju/nl80211-Add-LC-placeholder-band-definition-to-nl80211_band/20211018-190152
        git checkout ae5d24705bf40b9954a995fd7d768ab4cc879bc2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/purelifi/plfxlc/usb.c:55:7: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]
                   if (!tx->station[sidx].flag & STATION_CONNECTED_FLAG)
                       ^                       ~
   drivers/net/wireless/purelifi/plfxlc/usb.c:55:7: note: add parentheses after the '!' to evaluate the bitwise operator first
                   if (!tx->station[sidx].flag & STATION_CONNECTED_FLAG)
                       ^
                        (                                              )
   drivers/net/wireless/purelifi/plfxlc/usb.c:55:7: note: add parentheses around left hand side expression to silence this warning
                   if (!tx->station[sidx].flag & STATION_CONNECTED_FLAG)
                       ^
                       (                      )
   drivers/net/wireless/purelifi/plfxlc/usb.c:38:19: warning: unused function 'get_bcd_device' [-Wunused-function]
   static inline u16 get_bcd_device(const struct usb_device *udev)
                     ^
   2 warnings generated.
--
>> drivers/net/wireless/purelifi/plfxlc/mac.c:560:25: warning: parameter 'changed_flags' set but not used [-Wunused-but-set-parameter]
                                          unsigned int changed_flags,
                                                       ^
   1 warning generated.

vim +55 drivers/net/wireless/purelifi/plfxlc/usb.c

    42	
    43	void purelifi_send_packet_from_data_queue(struct purelifi_usb *usb)
    44	{
    45		struct sk_buff *skb = NULL;
    46		unsigned long flags;
    47		static u8 sidx;
    48		u8 last_served_sidx;
    49		struct purelifi_usb_tx *tx = &usb->tx;
    50	
    51		spin_lock_irqsave(&tx->lock, flags);
    52		last_served_sidx = sidx;
    53		do {
    54			sidx = (sidx + 1) % MAX_STA_NUM;
  > 55			if (!tx->station[sidx].flag & STATION_CONNECTED_FLAG)
    56				continue;
    57			if (!(tx->station[sidx].flag & STATION_FIFO_FULL_FLAG))
    58				skb = skb_peek(&tx->station[sidx].data_list);
    59		} while ((sidx != last_served_sidx) && (!skb));
    60	
    61		if (skb) {
    62			skb = skb_dequeue(&tx->station[sidx].data_list);
    63			plf_usb_wreq_async(usb, skb->data, skb->len, USB_REQ_DATA_TX,
    64					   tx_urb_complete, skb);
    65			if (skb_queue_len(&tx->station[sidx].data_list) <= 60)
    66				ieee80211_wake_queues(purelifi_usb_to_hw(usb));
    67		}
    68		spin_unlock_irqrestore(&tx->lock, flags);
    69	}
    70	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37065 bytes --]