From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
<kishon@ti.com>, <robh+dt@kernel.org>, <andrew@lunn.ch>,
<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] phy: Add lan966x ethernet serdes PHY driver
Date: Thu, 28 Oct 2021 10:57:47 +0200 [thread overview]
Message-ID: <20211028085747.hhpbcfaevmt4wrl2@soft-dev3-1.localhost> (raw)
In-Reply-To: <YXGoGtbFeKa+TVk2@matsya>
The 10/21/2021 23:19, Vinod Koul wrote:
>
> On 21-10-21, 11:10, Horatiu Vultur wrote:
> > The 10/21/2021 11:40, Vinod Koul wrote:
> > >
> > > On 20-10-21, 17:49, Alexandre Belloni wrote:
> > > > On 20/10/2021 21:05:49+0530, Vinod Koul wrote:
> > > > > > > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > > > > > >
> > > > > > > Any reason why this is dual licensed, why not GPL only?
> > > > > >
> > > > > > No reason, I think I copy this from a different file.
> > > > >
> > > > > Please have a chat with your lawyers on the correct license this should
> > > > > have!
> > > > Dual GPL and MIT was Microsemi's policy, I'm not sure it carried over to
> > > > Microchip.
> > >
> > > That is why they need to talk to someone and decide what license
> > > applies :)
> >
> > I have changed it to be the same as the one on sparx5 because also
> > sparx5 is a Microchip product. On sparx5 we used:
> > 'SPDX-License-Identifier: GPL-2.0-or-later'
>
> Has the code been copied/derived from somewhere/auto generated from
> scripts/tools or entirely written by you?
Sorry for late reply, but I was out of office without access to the
emails.
The register file 'lan966x_serdes_regs.h' was autogenerated from some
internal scripts. Which takes the info from here [1] and generates these
header files. The reason why we generate them is that is more error proof
that writting them manually. We are doing the same for sparx5
registers[2]
The other file 'lan966x_serdes.c' was entirely written by me.
[1] https://github.com/microchip-ung/lan9668_reginfo
[2] https://elixir.bootlin.com/linux/latest/source/drivers/phy/microchip/sparx5_serdes_regs.h
>
> --
> ~Vinod
--
/Horatiu
prev parent reply other threads:[~2021-10-28 8:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 12:39 [PATCH v3 0/3] Add driver for lan966x Serdes driver Horatiu Vultur
2021-10-15 12:39 ` [PATCH v3 1/3] dt-bindings: phy: Add lan966x-serdes binding Horatiu Vultur
2021-10-15 12:39 ` [PATCH v3 2/3] dt-bindings: phy: Add constants for lan966x serdes Horatiu Vultur
2021-10-18 19:28 ` Rob Herring
2021-10-19 9:12 ` Horatiu Vultur
2021-10-19 13:38 ` Rob Herring
2021-10-20 9:07 ` Horatiu Vultur
2021-10-15 12:39 ` [PATCH v3 3/3] phy: Add lan966x ethernet serdes PHY driver Horatiu Vultur
2021-10-19 17:57 ` Vinod Koul
2021-10-20 9:17 ` Horatiu Vultur
2021-10-20 15:35 ` Vinod Koul
2021-10-20 15:49 ` Alexandre Belloni
2021-10-21 6:10 ` Vinod Koul
2021-10-21 9:10 ` Horatiu Vultur
2021-10-21 17:49 ` Vinod Koul
2021-10-28 8:57 ` Horatiu Vultur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028085747.hhpbcfaevmt4wrl2@soft-dev3-1.localhost \
--to=horatiu.vultur@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).