* [PATCH v2 1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity
@ 2021-10-31 23:41 Paul Cercueil
2021-10-31 23:41 ` [PATCH v2 2/2] ARM: dts: exynos/i9100: Use interrupt for BCM4330 host wakeup Paul Cercueil
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Paul Cercueil @ 2021-10-31 23:41 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Paul Cercueil, stable
The reset GPIO was marked active-high, which is against what's specified
in the documentation. Mark the reset GPIO as active-low. With this
change, Bluetooth can now be used on the i9100.
Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for the Galaxy S2")
Cc: stable@vger.kernel.org
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
arch/arm/boot/dts/exynos4210-i9100.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts
index 55922176807e..5f5d9b135736 100644
--- a/arch/arm/boot/dts/exynos4210-i9100.dts
+++ b/arch/arm/boot/dts/exynos4210-i9100.dts
@@ -827,7 +827,7 @@ bluetooth {
compatible = "brcm,bcm4330-bt";
shutdown-gpios = <&gpl0 4 GPIO_ACTIVE_HIGH>;
- reset-gpios = <&gpl1 0 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpl1 0 GPIO_ACTIVE_LOW>;
device-wakeup-gpios = <&gpx3 1 GPIO_ACTIVE_HIGH>;
host-wakeup-gpios = <&gpx2 6 GPIO_ACTIVE_HIGH>;
};
--
2.33.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] ARM: dts: exynos/i9100: Use interrupt for BCM4330 host wakeup
2021-10-31 23:41 [PATCH v2 1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity Paul Cercueil
@ 2021-10-31 23:41 ` Paul Cercueil
2021-11-02 7:53 ` [PATCH v2 1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity Krzysztof Kozlowski
2021-11-15 13:11 ` Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Paul Cercueil @ 2021-10-31 23:41 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Paul Cercueil
Switch away from using the deprecated 'host-wakeup-gpios' property,
and use a 'host-wakeup' interrupt instead, as suggested by the binding
documentation.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
arch/arm/boot/dts/exynos4210-i9100.dts | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts
index 5f5d9b135736..76b1017e05e8 100644
--- a/arch/arm/boot/dts/exynos4210-i9100.dts
+++ b/arch/arm/boot/dts/exynos4210-i9100.dts
@@ -829,7 +829,10 @@ bluetooth {
shutdown-gpios = <&gpl0 4 GPIO_ACTIVE_HIGH>;
reset-gpios = <&gpl1 0 GPIO_ACTIVE_LOW>;
device-wakeup-gpios = <&gpx3 1 GPIO_ACTIVE_HIGH>;
- host-wakeup-gpios = <&gpx2 6 GPIO_ACTIVE_HIGH>;
+
+ interrupt-parent = <&gpx2>;
+ interrupts = <6 IRQ_TYPE_EDGE_FALLING>;
+ interrupt-names = "host-wakeup";
};
};
--
2.33.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity
2021-10-31 23:41 [PATCH v2 1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity Paul Cercueil
2021-10-31 23:41 ` [PATCH v2 2/2] ARM: dts: exynos/i9100: Use interrupt for BCM4330 host wakeup Paul Cercueil
@ 2021-11-02 7:53 ` Krzysztof Kozlowski
2021-11-15 13:11 ` Krzysztof Kozlowski
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-02 7:53 UTC (permalink / raw)
To: Paul Cercueil, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel, stable
On 01/11/2021 00:41, Paul Cercueil wrote:
> The reset GPIO was marked active-high, which is against what's specified
> in the documentation. Mark the reset GPIO as active-low. With this
> change, Bluetooth can now be used on the i9100.
>
> Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for the Galaxy S2")
> Cc: stable@vger.kernel.org
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> arch/arm/boot/dts/exynos4210-i9100.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Looks good, thanks. I'll take it after the merge window.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity
2021-10-31 23:41 [PATCH v2 1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity Paul Cercueil
2021-10-31 23:41 ` [PATCH v2 2/2] ARM: dts: exynos/i9100: Use interrupt for BCM4330 host wakeup Paul Cercueil
2021-11-02 7:53 ` [PATCH v2 1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity Krzysztof Kozlowski
@ 2021-11-15 13:11 ` Krzysztof Kozlowski
2021-11-15 13:31 ` Krzysztof Kozlowski
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-15 13:11 UTC (permalink / raw)
To: Rob Herring, Paul Cercueil
Cc: Krzysztof Kozlowski, linux-kernel, stable, linux-arm-kernel,
devicetree, linux-samsung-soc
On Sun, 31 Oct 2021 23:41:36 +0000, Paul Cercueil wrote:
> The reset GPIO was marked active-high, which is against what's specified
> in the documentation. Mark the reset GPIO as active-low. With this
> change, Bluetooth can now be used on the i9100.
>
>
Applied, thanks!
[1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity
commit: 9cb6de45a006a9799ec399bce60d64b6d4fcc4af
[2/2] ARM: dts: exynos/i9100: Use interrupt for BCM4330 host wakeup
commit: 8e14b530f8c90346eab43c7b59b03ff9fec7d171
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity
2021-11-15 13:11 ` Krzysztof Kozlowski
@ 2021-11-15 13:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-15 13:31 UTC (permalink / raw)
To: Rob Herring, Paul Cercueil
Cc: linux-kernel, stable, linux-arm-kernel, devicetree, linux-samsung-soc
On 15/11/2021 14:11, Krzysztof Kozlowski wrote:
> On Sun, 31 Oct 2021 23:41:36 +0000, Paul Cercueil wrote:
>> The reset GPIO was marked active-high, which is against what's specified
>> in the documentation. Mark the reset GPIO as active-low. With this
>> change, Bluetooth can now be used on the i9100.
>>
>>
>
> Applied, thanks!
>
> [1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity
> commit: 9cb6de45a006a9799ec399bce60d64b6d4fcc4af
> [2/2] ARM: dts: exynos/i9100: Use interrupt for BCM4330 host wakeup
> commit: 8e14b530f8c90346eab43c7b59b03ff9fec7d171
>
Applied with fixed title. Please use prefix matching history (git log
--oneline).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-15 13:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-31 23:41 [PATCH v2 1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity Paul Cercueil
2021-10-31 23:41 ` [PATCH v2 2/2] ARM: dts: exynos/i9100: Use interrupt for BCM4330 host wakeup Paul Cercueil
2021-11-02 7:53 ` [PATCH v2 1/2] ARM: dts: exynos/i9100: Fix BCM4330 Bluetooth reset polarity Krzysztof Kozlowski
2021-11-15 13:11 ` Krzysztof Kozlowski
2021-11-15 13:31 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).