From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6726DC433EF for ; Mon, 1 Nov 2021 01:40:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C4CF61075 for ; Mon, 1 Nov 2021 01:40:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230395AbhKABnA (ORCPT ); Sun, 31 Oct 2021 21:43:00 -0400 Received: from gw2.atmark-techno.com ([35.74.137.57]:34674 "EHLO gw2.atmark-techno.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230234AbhKABm4 (ORCPT ); Sun, 31 Oct 2021 21:42:56 -0400 Received: from gw2.atmark-techno.com (localhost [127.0.0.1]) by gw2.atmark-techno.com (Postfix) with ESMTP id E218420D20 for ; Mon, 1 Nov 2021 10:34:35 +0900 (JST) Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by gw2.atmark-techno.com (Postfix) with ESMTPS id AAD3920D49 for ; Mon, 1 Nov 2021 10:34:34 +0900 (JST) Received: by mail-pf1-f199.google.com with SMTP id w30-20020aa79a1e000000b0048012d2e882so2965280pfj.2 for ; Sun, 31 Oct 2021 18:34:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ca7wg6azCq3ny4hWbrL7FZo7O/uh31XvAyJngwZlrgA=; b=6AfPt0JwVI7h2EhASBVUa8bAvBI4QUXZkK2o3T3AQOMUUcX/aB3KgXZq75EV6MdCrd V+b0WH1oZbZ65auXC9KRHeLqQeJB3oEg13bm89j7SxMcMe+UCsMwzhafyQ8+ZUkaLvPF wmhFc4PICxzYOIcP5TGAg1jDa/pZ3DDDU1nKMwoU30u/yk/JzQNNv3f9Qf7Lz/LPcNB0 FJF4DtSUKjsBvWeXswp8dZ3FaoRlM0Lh1609kYqvUboLMlCoe4sKzS3rGWJGkpXx3TpB PF4i+Y//BCngywr0wbyGDJepiFcpE4TbWwHxoszzpb6l9veVI+xvhhAEDb/cdRedynSa VXbg== X-Gm-Message-State: AOAM530mhRjns54N6gSYJ1zpwOYTpsFXP0cb/otcwaW60+8WGhrp6Cel 9Xc9uYXHWlGlJYflE8hMrxoKwBlB2slWzYN0CmD0m+RdG44A/qzjpozXCpehHkaagW/jF7y89q9 hjb48UmbS8uPTUEqtM4xYpsYNmg== X-Received: by 2002:a65:5b01:: with SMTP id y1mr2801179pgq.451.1635730473397; Sun, 31 Oct 2021 18:34:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAr8Wl5STLCJtM9Gz8JdkYbOBmkcp5/N5mU58hqMgWrR+/H4n45yWCEgqe4Qq4nPx99PB2PQ== X-Received: by 2002:a65:5b01:: with SMTP id y1mr2801164pgq.451.1635730473161; Sun, 31 Oct 2021 18:34:33 -0700 (PDT) Received: from pc-0115 (76.125.194.35.bc.googleusercontent.com. [35.194.125.76]) by smtp.gmail.com with ESMTPSA id np17sm17262733pjb.7.2021.10.31.18.34.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Oct 2021 18:34:32 -0700 (PDT) Received: from martinet by pc-0115 with local (Exim 4.94.2) (envelope-from ) id 1mhMDX-001Mmf-Nu; Mon, 01 Nov 2021 10:34:31 +0900 From: Dominique Martinet To: Alexandre Belloni , Alessandro Zummo Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Vasut , Rob Herring , Dominique Martinet Subject: [PATCH 2/2] rv8803: add irq-gpio optional dts attribute Date: Mon, 1 Nov 2021 10:34:00 +0900 Message-Id: <20211101013400.325855-2-dominique.martinet@atmark-techno.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211101013400.325855-1-dominique.martinet@atmark-techno.com> References: <20211101013400.325855-1-dominique.martinet@atmark-techno.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some device cannot be woken up from i2c signal. Add a new irq-gpio attribute for devices which have a gpio connected to the rv8803 INT line so the rtc can be used for suspend to mem Signed-off-by: Dominique Martinet --- Our board does not have an upstream dts so I cannot provide a real example for it, but I've tested this on something close to the imx8mp-evk. It should not break anything for people having no alarm at all or using the i2c irq. .../devicetree/bindings/rtc/epson,rx8900.yaml | 5 ++ drivers/rtc/rtc-rv8803.c | 73 +++++++++++++++++-- 2 files changed, 73 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8900.yaml b/Documentation/devicetree/bindings/rtc/epson,rx8900.yaml index 29fe39bb08ad..0d7912b984c7 100644 --- a/Documentation/devicetree/bindings/rtc/epson,rx8900.yaml +++ b/Documentation/devicetree/bindings/rtc/epson,rx8900.yaml @@ -28,6 +28,10 @@ properties: trickle-diode-disable: true + irq-gpio: + description: | + gpio for INT signal. Set up gpio for irq and device wakeup. + required: - compatible - reg @@ -45,5 +49,6 @@ examples: reg = <0x32>; epson,vdet-disable; trickle-diode-disable; + irq-gpio = <&gpio1 11 GPIO_ACTIVE_LOW>; }; }; diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c index 0d5ed38bf60c..1c4b96bc110e 100644 --- a/drivers/rtc/rtc-rv8803.c +++ b/drivers/rtc/rtc-rv8803.c @@ -16,6 +16,7 @@ #include #include #include +#include #define RV8803_I2C_TRY_COUNT 4 @@ -509,6 +510,61 @@ static int rx8900_trickle_charger_init(struct rv8803_data *rv8803) flags); } +static int rv8803_setup_gpio_irq(struct i2c_client *client) +{ + struct device *dev = &client->dev; + int err; + int irq; + unsigned long irqflags; + struct gpio_desc *gpiod; + + + gpiod = devm_gpiod_get_from_of_node(dev, dev->of_node, "irq-gpio", + 0, GPIOD_IN, "RTC irq pin"); + if (!gpiod || IS_ERR(gpiod)) { + dev_dbg(dev, "no gpio for rtc: skipping\n"); + return -ENOENT; + } + + irq = gpiod_to_irq(gpiod); + if (irq < 0) { + dev_err(dev, "gpio found but no irq\n"); + err = irq; + goto error_gpio; + } + + irqflags = IRQF_ONESHOT; + irqflags |= gpiod_is_active_low(gpiod) ? + IRQF_TRIGGER_FALLING : IRQF_TRIGGER_RISING; + + err = devm_request_threaded_irq(dev, irq, NULL, rv8803_handle_irq, + irqflags, "rtc-rv8803-gpio", client); + if (err) { + dev_warn(dev, "unable to request IRQ\n"); + goto error_gpio; + } + + err = device_init_wakeup(dev, true); + if (err) { + dev_warn(dev, "unable to set as wakeup source\n"); + goto error_irq; + } + + err = dev_pm_set_wake_irq(dev, irq); + if (err) { + dev_warn(dev, "unable to set wake irq\n"); + goto error_irq; + } + + return 0; + +error_irq: + devm_free_irq(dev, irq, client); +error_gpio: + devm_gpiod_put(dev, gpiod); + return err; +} + static int rv8803_probe(struct i2c_client *client, const struct i2c_device_id *id) { @@ -524,6 +580,7 @@ static int rv8803_probe(struct i2c_client *client, .reg_write = rv8803_nvram_write, .priv = client, }; + bool irq_setup = false; if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_I2C_BLOCK)) { @@ -562,17 +619,23 @@ static int rv8803_probe(struct i2c_client *client, if (IS_ERR(rv8803->rtc)) return PTR_ERR(rv8803->rtc); - if (client->irq > 0) { + if (client->dev.of_node) { + err = rv8803_setup_gpio_irq(client); + if (!err) + irq_setup = true; + } + + if (!irq_setup && client->irq > 0) { err = devm_request_threaded_irq(&client->dev, client->irq, NULL, rv8803_handle_irq, IRQF_TRIGGER_LOW | IRQF_ONESHOT, "rv8803", client); - if (err) { + if (err) dev_warn(&client->dev, "unable to request IRQ, alarms disabled\n"); - client->irq = 0; - } + else + irq_setup = true; } - if (!client->irq) + if (!irq_setup) clear_bit(RTC_FEATURE_ALARM, rv8803->rtc->features); err = rv8803_write_reg(rv8803->client, RV8803_EXT, RV8803_EXT_WADA); -- 2.30.2