From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 872F7C433EF for ; Mon, 1 Nov 2021 08:12:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7088761075 for ; Mon, 1 Nov 2021 08:12:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231860AbhKAIOh (ORCPT ); Mon, 1 Nov 2021 04:14:37 -0400 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:56173 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231812AbhKAIOe (ORCPT ); Mon, 1 Nov 2021 04:14:34 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=wuzongyong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0UuW7e4W_1635754319; Received: from localhost(mailfrom:wuzongyong@linux.alibaba.com fp:SMTPD_---0UuW7e4W_1635754319) by smtp.aliyun-inc.com(127.0.0.1); Mon, 01 Nov 2021 16:11:59 +0800 Date: Mon, 1 Nov 2021 16:11:59 +0800 From: Wu Zongyong To: Jason Wang Cc: virtualization , linux-kernel , mst , wei.yang1@linux.alibaba.com Subject: Re: [PATCH v7 0/9] vDPA driver for Alibaba ENI Message-ID: <20211101081159.GA4341@L-PF27918B-1352.localdomain> Reply-To: Wu Zongyong References: <20211101062250.GA29814@L-PF27918B-1352.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 01, 2021 at 03:02:52PM +0800, Jason Wang wrote: > On Mon, Nov 1, 2021 at 2:23 PM Wu Zongyong wrote: > > > > On Mon, Nov 01, 2021 at 11:31:15AM +0800, Jason Wang wrote: > > > On Fri, Oct 29, 2021 at 5:15 PM Wu Zongyong > > > wrote: > > > > > > > > This series implements the vDPA driver for Alibaba ENI (Elastic Network > > > > Interface) which is built based on virtio-pci 0.9.5 specification. > > > > > > It looks to me Michael has applied the patches, if this is the case, > > > we probably need to send patches on top. > > > > What do you mean by saying "send patches on top"? > > Sorry, I'm a newbie to contribute for kernel, could you please explain > > it in detail? > > I meant you probably need to send incremental patch on top of: > > git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next. Get it. Thanks > > Thanks > > > > > > Thanks > > > Thanks > > > > > > > > > > > Changes since V6: > > > > - set default min vq size to 1 intead of 0 > > > > - enable eni vdpa driver only on X86 hosts > > > > - fix some typos > > > > > > > > Changes since V5: > > > > - remove unused codes > > > > > > > > Changes since V4: > > > > - check return values of get_vq_num_{max,min} when probing devices > > > > - disable the driver on BE host via Kconfig > > > > - add missing commit message > > > > > > > > Changes since V3: > > > > - validate VIRTIO_NET_F_MRG_RXBUF when negotiate features > > > > - present F_ORDER_PLATFORM in get_features > > > > - remove endian check since ENI always use litter endian > > > > > > > > Changes since V2: > > > > - add new attribute VDPA_ATTR_DEV_MIN_VQ_SIZE instead > > > > VDPA_ATTR_DEV_F_VERSION_1 to guide users to choose correct virtqueue > > > > size as suggested by Jason Wang > > > > - present ACCESS_PLATFORM in get_features callback as suggested by Jason > > > > Wang > > > > - disable this driver on Big Endian host as suggested by Jason Wang > > > > - fix a typo > > > > > > > > Changes since V1: > > > > - add new vdpa attribute VDPA_ATTR_DEV_F_VERSION_1 to indicate whether > > > > the vdpa device is legacy > > > > - implement dedicated driver for Alibaba ENI instead a legacy virtio-pci > > > > driver as suggested by Jason Wang > > > > - some bugs fixed > > > > > > > > Wu Zongyong (9): > > > > virtio-pci: introduce legacy device module > > > > vdpa: fix typo > > > > vp_vdpa: add vq irq offloading support > > > > vdpa: add new callback get_vq_num_min in vdpa_config_ops > > > > vdpa: min vq num of vdpa device cannot be greater than max vq num > > > > virtio_vdpa: setup correct vq size with callbacks get_vq_num_{max,min} > > > > vdpa: add new attribute VDPA_ATTR_DEV_MIN_VQ_SIZE > > > > eni_vdpa: add vDPA driver for Alibaba ENI > > > > eni_vdpa: alibaba: fix Kconfig typo > > > > > > > > drivers/vdpa/Kconfig | 8 + > > > > drivers/vdpa/Makefile | 1 + > > > > drivers/vdpa/alibaba/Makefile | 3 + > > > > drivers/vdpa/alibaba/eni_vdpa.c | 553 +++++++++++++++++++++++++ > > > > drivers/vdpa/vdpa.c | 13 + > > > > drivers/vdpa/virtio_pci/vp_vdpa.c | 12 + > > > > drivers/virtio/Kconfig | 10 + > > > > drivers/virtio/Makefile | 1 + > > > > drivers/virtio/virtio_pci_common.c | 10 +- > > > > drivers/virtio/virtio_pci_common.h | 9 +- > > > > drivers/virtio/virtio_pci_legacy.c | 101 ++--- > > > > drivers/virtio/virtio_pci_legacy_dev.c | 220 ++++++++++ > > > > drivers/virtio/virtio_vdpa.c | 16 +- > > > > include/linux/vdpa.h | 6 +- > > > > include/linux/virtio_pci_legacy.h | 42 ++ > > > > include/uapi/linux/vdpa.h | 1 + > > > > 16 files changed, 917 insertions(+), 89 deletions(-) > > > > create mode 100644 drivers/vdpa/alibaba/Makefile > > > > create mode 100644 drivers/vdpa/alibaba/eni_vdpa.c > > > > create mode 100644 drivers/virtio/virtio_pci_legacy_dev.c > > > > create mode 100644 include/linux/virtio_pci_legacy.h > > > > > > > > -- > > > > 2.31.1 > > > > > >