linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 5.15
Date: Mon, 1 Nov 2021 20:19:31 -0700	[thread overview]
Message-ID: <20211102031931.GA437868@roeck-us.net> (raw)
In-Reply-To: <CAHk-=wiZgzKMw7AkahZH-iCxJLAadS_nrzVJiCqrsFWfg7n_Xw@mail.gmail.com>

On Mon, Nov 01, 2021 at 06:44:39PM -0700, Linus Torvalds wrote:
> On Mon, Nov 1, 2021 at 6:18 PM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > Replacing "strlen(UTS_RELEASE)" with "sizeof(UTS_RELEASE) - 1" seems to do
> > the trick, at least with gcc 11.2 and v5.15. I just wonder if that would be
> > acceptable. Any idea ?
> 
> Looks sane to me.
> 
> I don't understand why gcc complains about that thing in the first
> place, much less why it only happens on m68k, but whatever...
> 
> The other - and perhaps better - option would be to just uninline
> memcpy_and_pad() entirely, move it to lib/string.c, and only have the
> declaration in <linux/string.h>.
> 
> Because the only reason to have it as an inline function is when the
> compiler can statically optimize a call site: but it's really not a
> performance-critical function to begin with, and clearly the compiler
> instead just *breaks* rather than optimize that call-site.
> 
Excellent suggestion. I'll submit a patch to do just that.

Thanks,
Guenter

  reply	other threads:[~2021-11-02  3:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-31 21:09 Linus Torvalds
2021-11-01  0:23 ` Guenter Roeck
2021-11-01  8:13   ` Geert Uytterhoeven
2021-11-02  1:17     ` Guenter Roeck
2021-11-02  1:44       ` Linus Torvalds
2021-11-02  3:19         ` Guenter Roeck [this message]
2021-11-01  4:49 ` Thorsten is tracking regression again and could need a little help (was: Re: Linux 5.15) Thorsten Leemhuis
     [not found]   ` <c11d94b4-1701-4e26-efd1-42038342c4aa@kaputniks.org>
2021-11-01 11:56     ` Greg KH
2021-11-01 12:54     ` Thorsten Leemhuis
2021-11-01 12:33   ` Greg KH
2021-11-01 12:44     ` Thorsten Leemhuis
2021-11-01 13:03       ` Greg KH
2021-11-01 13:34         ` Thorsten Leemhuis
2021-11-01 15:27           ` Greg KH
2021-11-01 16:19             ` Thorsten Leemhuis
2021-11-01 15:07 ` Linux 5.15 Andy Shevchenko
2021-11-01 16:19   ` Lee Jones
2021-11-01 17:25 ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211102031931.GA437868@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: Linux 5.15' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).