* [PATCH] i2c: xgene-slimpro: Fix inconsistent IS_ERR and PTR_ERR
@ 2021-11-02 2:12 Wan Jiabing
2021-11-02 9:01 ` Sudeep Holla
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-11-02 2:12 UTC (permalink / raw)
To: Wolfram Sang, Zhiqi Song, Tian Tao, Florian Fainelli,
Wan Jiabing, Sudeep Holla, linux-i2c, linux-kernel
Cc: jiabing.wan
Fix following coccicheck warning:
./drivers/i2c/busses/i2c-xgene-slimpro.c:488:6-12: inconsistent IS_ERR
and PTR_ERR on line 490.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/i2c/busses/i2c-xgene-slimpro.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c
index 1a19ebad60ad..63259b3ea5ab 100644
--- a/drivers/i2c/busses/i2c-xgene-slimpro.c
+++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
@@ -487,7 +487,7 @@ static int xgene_slimpro_i2c_probe(struct platform_device *pdev)
pcc_chan = pcc_mbox_request_channel(cl, ctx->mbox_idx);
if (IS_ERR(pcc_chan)) {
dev_err(&pdev->dev, "PCC mailbox channel request failed\n");
- return PTR_ERR(ctx->pcc_chan);
+ return PTR_ERR(pcc_chan);
}
ctx->pcc_chan = pcc_chan;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: xgene-slimpro: Fix inconsistent IS_ERR and PTR_ERR
2021-11-02 2:12 [PATCH] i2c: xgene-slimpro: Fix inconsistent IS_ERR and PTR_ERR Wan Jiabing
@ 2021-11-02 9:01 ` Sudeep Holla
0 siblings, 0 replies; 2+ messages in thread
From: Sudeep Holla @ 2021-11-02 9:01 UTC (permalink / raw)
To: Wan Jiabing
Cc: Wolfram Sang, Zhiqi Song, Tian Tao, Florian Fainelli, linux-i2c,
Sudeep Holla, linux-kernel, jiabing.wan
Hi Wan,
On Mon, Nov 01, 2021 at 10:12:27PM -0400, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/i2c/busses/i2c-xgene-slimpro.c:488:6-12: inconsistent IS_ERR
> and PTR_ERR on line 490.
There is another version @[1]. Thanks for the effort.
Hi Wolfram,
Can you pick [1] after -rc1 ? I see mailbox updates are in the mainline
already.
--
Regards,
Sudeep
[1] https://lore.kernel.org/kernel-janitors/20211101140235.777322-1-weiyongjun1@huawei.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-02 9:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-02 2:12 [PATCH] i2c: xgene-slimpro: Fix inconsistent IS_ERR and PTR_ERR Wan Jiabing
2021-11-02 9:01 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).